Skip to content

Commit b9eb637

Browse files
committed
fix: withType has different behavior in 1.21.3+ and refuses to replace air. GG minecraft.
1 parent cf6bc18 commit b9eb637

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

vane-core/src/main/java/org/oddlama/vane/util/ItemUtil.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,11 @@ public static ItemStack set_lore(final ItemStack item, final List<Component> lor
101101
}
102102

103103
public static ItemStack name_item(final ItemStack item, Component name, final List<Component> lore) {
104-
final var meta = item.getItemMeta();
104+
var meta = item.getItemMeta();
105+
if (meta == null) {
106+
// Cannot name item without meta (probably air)
107+
return item;
108+
}
105109

106110
name = name.decoration(TextDecoration.ITALIC, false);
107111
meta.displayName(name);

vane-portals/src/main/java/org/oddlama/vane/portals/menu/StyleMenu.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -539,7 +539,7 @@ private MenuWidget menu_item_block_selector(
539539
public void item(final ItemStack item) {
540540
var stack = item_for_type(style_container, active, type);
541541
if (stack.getType() == Material.AIR) {
542-
stack = stack.withType(Material.BARRIER);
542+
stack = new ItemStack(Material.BARRIER);
543543
}
544544
super.item(t_item.alternative(stack, "§6" + building_material.getKey()));
545545
}

0 commit comments

Comments
 (0)