Change dof_residual definition to not depend on dispersion parameter #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #560 +/- ##
==========================================
- Coverage 89.86% 89.85% -0.01%
==========================================
Files 8 8
Lines 1125 1124 -1
==========================================
- Hits 1011 1010 -1
Misses 114 114 ☔ View full report in Codecov by Sentry. |
andreasnoack
force-pushed
the
an/dof_residual
branch
from
60add18
to
5c26648
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #509
There was actually already a test of a model affected by this but the reference value was wrong. I checked the value in R.
@nalimilan how do you feel about
dofafter all these years? After preparing this, I think we might be better of from deprecatingdof(which would have to happen inStatsAPI). I tend to think that it brings more confusion than convenience.