-
Notifications
You must be signed in to change notification settings - Fork 9
Open
Description
Unfortunately, Julia Base has only limited use of traits.
DenseArray for opting into/out of BLAS/LAPACK is instead part of a type tree.
The fix (other than switching Base to a trait-based approach) is to define two separate type trees within StrideArraysCore, one for dense instances, and the other for non.
Currently, all subtype dense.
There is already a precendent for libraries doing this even when not valid for BLAS https://github.com/JuliaGPU/GPUArrays.jl/blob/6becb4fdfe213d327acab47225595ad9df785dfd/src/device/abstractarray.jl#L15
so probably not the end of the world to lie for now.
On the other hand, not lying has serious consequences JuliaSIMD/Polyester.jl#127
Metadata
Metadata
Assignees
Labels
No labels