Skip to content

Not always a DenseArray!!! #45

@chriselrod

Description

@chriselrod

Unfortunately, Julia Base has only limited use of traits.

DenseArray for opting into/out of BLAS/LAPACK is instead part of a type tree.

The fix (other than switching Base to a trait-based approach) is to define two separate type trees within StrideArraysCore, one for dense instances, and the other for non.

Currently, all subtype dense.
There is already a precendent for libraries doing this even when not valid for BLAS https://github.com/JuliaGPU/GPUArrays.jl/blob/6becb4fdfe213d327acab47225595ad9df785dfd/src/device/abstractarray.jl#L15
so probably not the end of the world to lie for now.

On the other hand, not lying has serious consequences JuliaSIMD/Polyester.jl#127

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions