-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GenerativeBeliefMDP isterminal is only true when the support is entirely terminal #544
Comments
@FlyingWorkshop did you close this because it was resolved? If it can throw an error when it samples a terminal state, we should probably fix that. I think |
@zsunberg, I closed it b/c I took a look at the source code again and realized that while I was testing this on |
This isn't an error per say, but
isterminal
inGenerativeBeliefMDP
is only true when the entire support is terminal, but when@gen
is called, we sample single state from the belief, meaningisterminal(bmdp, b = false)
, but@gen(b, a)
may fail because a terminal state is sampled. Is there a good reason to define "terminal belief" this way? I agree that checking if any terminal state is in the support might be overly reactive. This becomes a problem, for instance, when we want to generate a bunch of samples and early exit on a "terminal belief."The text was updated successfully, but these errors were encountered: