fix: fix n-dimensional view
into n-dimensional SArray
with Any
eltype
#1310
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of the latest release, trying to
view
into anSArray
with an eltype ofAny
such that the view also returns anSArray
would wrap the returned array in a scalar._maybewrapscalar
assumes that if theeltype
of the array matches the type of the view, it must be a scalar view. This assumption breaks down when theeltype
isAny
. MWE:I've verified that all the added tests fail on the latest release and pass with this PR.