Skip to content

Commit 0596799

Browse files
committed
moving log_evaluation method to export
1 parent 972f2dc commit 0596799

File tree

2 files changed

+7
-8
lines changed

2 files changed

+7
-8
lines changed

src/MLJBase.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -349,7 +349,7 @@ export TransformedTargetModel
349349

350350
# resampling.jl:
351351
export ResamplingStrategy, Holdout, CV, StratifiedCV, TimeSeriesCV,
352-
evaluate!, Resampler, PerformanceEvaluation
352+
evaluate!, Resampler, PerformanceEvaluation, log_evaluation
353353

354354
# `MLJType` and the abstract `Model` subtypes are exported from within
355355
# src/composition/abstract_types.jl

src/resampling.jl

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1163,20 +1163,19 @@ end
11631163

11641164
# Workflow logging interfaces, such as MLJFlow (MLFlow connection via
11651165
# MLFlowClient.jl), overload the following method but replace the `logger`
1166-
# argument with `logger::LoggerType`, where `LoggerType <: MLJLogger`
1167-
# is specific to the logging platform.
1168-
abstract type MLJLogger end
1166+
# argument with `logger::LoggerType`, where `LoggerType` is specific to the
1167+
# logging platform.
11691168
"""
1170-
log_evaluation(logger::MLJLogger, performance_evaluation)
1169+
log_evaluation(logger, performance_evaluation)
11711170
11721171
Logs a performance evaluation (the returning object from `evaluate!`)
11731172
to a logging platform. The default implementation does nothing.
11741173
Can be overloaded by logging interfaces, such as MLJFlow (MLFlow
11751174
connection via MLFlowClient.jl), which replace the `logger` argument
1176-
with `logger::LoggerType`, where `LoggerType <: MLJLogger` is specific
1177-
to the logging platform.
1175+
with `logger::LoggerType`, where `LoggerType` is specific to the logging
1176+
platform.
11781177
"""
1179-
log_evaluation(logger::MLJLogger, performance_evaluation) = nothing
1178+
log_evaluation(logger, performance_evaluation) = nothing
11801179

11811180
# Evaluation when `resampling` is a TrainTestPairs (CORE EVALUATOR):
11821181
function evaluate!(mach::Machine, resampling, weights,

0 commit comments

Comments
 (0)