Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to add plot recipes in a new model implementation #1078

Open
ablaom opened this issue Jan 9, 2024 · 4 comments
Open

Document how to add plot recipes in a new model implementation #1078

ablaom opened this issue Jan 9, 2024 · 4 comments
Labels

Comments

@ablaom
Copy link
Member

ablaom commented Jan 9, 2024

@MilesCranmer Any chance you could add a couple of lines, maybe just pointing to your implementation as an example?

It could go somewhere here - if I don't like where you put it, no matter, I can move it.

@ablaom ablaom added the docs label Jan 9, 2024
@MilesCranmer
Copy link

MilesCranmer commented Jan 9, 2024

Sure, will do. I need to merge MilesCranmer/SymbolicRegression.jl#277 first as this creates a custom type SRFitResult for the fitresult used by SRRegressor, so that the recipe is assigned to only the fitresults from my regressors. I think this is the "right" way to do things and once its ready I will share the example (ping me if I forget!)

Current example: https://github.com/MilesCranmer/SymbolicRegression.jl/blob/4b6a3cd44f30bfa92e2fe1e53718ca85c61df088/src/PlotRecipes.jl

@MilesCranmer
Copy link

By the way, I think the new MLJBase version was not yet released? JuliaAI/MLJBase.jl@193ad67

@ablaom
Copy link
Member Author

ablaom commented Jan 10, 2024

@MilesCranmer
Copy link

Oh I see it now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants