Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug: Does not recreate dismissal_restrictions #14

Open
3 tasks done
JoshuaKGoldberg opened this issue Oct 2, 2023 · 2 comments
Open
3 tasks done

🐛 Bug: Does not recreate dismissal_restrictions #14

JoshuaKGoldberg opened this issue Oct 2, 2023 · 2 comments
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

Every part of a branch protection that is removed by this action should be re-added at the end of the action.

Actual

dismissal_restrictions had some odd typings and I don't need it for my personal repos... so I didn't implement it at first.

// TODO
// dismissal_restrictions: {
// apps: currentBranchProtections.data.required_pull_request_reviews.dismissal_restrictions?.apps?.map(
// // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
// (app) => app.slug!,
// ),
// teams:
// currentBranchProtections.data.required_pull_request_reviews.dismissal_restrictions?.teams?.map(
// (team) => team.slug,
// ),
// users:
// currentBranchProtections.data.required_pull_request_reviews.dismissal_restrictions?.users?.map(
// (user) => user.login,
// ),
// },

Accepting PRs to get it to work!

Additional Info

API docs for GitHub branch protections: https://docs.github.com/en/rest/branches/branch-protection?apiVersion=2022-11-28

@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels Oct 2, 2023
@JoshuaKGoldberg
Copy link
Owner Author

@all-contributors please add @JoshuaKGoldberg for bug.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

@allcontributors
Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @JoshuaKGoldberg! 🎉

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Development

No branches or pull requests

1 participant