Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention Hermes? #15

Open
henrymoulton opened this issue Jul 27, 2021 · 3 comments
Open

Mention Hermes? #15

henrymoulton opened this issue Jul 27, 2021 · 3 comments

Comments

@henrymoulton
Copy link

Hi Jonny,

Thanks for the library I've used it in most of my projects over the years. I believe that this is is creating a regular bundle to be interpreted with JSC and not the bundle/bytecode that would be interpreted by Hermes.

The final sizes might differ but it's still useful to examine the contents

@JonnyBurger
Copy link
Owner

Interesting, I did not consider it - I think the library also came out before Hermes was announced.

My goal is for this tool to show the bottlenecks and proportions of the bundle and I would assume they are the same for JSC than they are for Hermes.

Is it even the case that the RN bundler creates a different bundle depending on if it's JSC and Hermes? I thought both were just JS interpreters but it's the same JS.

@henrymoulton
Copy link
Author

Is it even the case that the RN bundler creates a different bundle depending on if it's JSC and Hermes? I thought both were just JS interpreters but it's the same JS.

No I don't believe so as Hermes is a bundle of bytecode rather than text.

This post gives a good overview about how to interact with the bundle.
https://suam.wtf/posts/react-native-application-static-analysis-en/

@JonnyBurger
Copy link
Owner

Since the bundle is the same for JSC and Hermes, I don't see how this tool should be adjusted for Hermes. It only looks at the data in on the bundle level, disregarding any JS engine optimizations that one might have in the stack. Also, I have no idea how technically this could be implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants