-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple issues with the build #1953
Labels
bug
Something is broken, we are tracking it
Comments
I think we'd need an internal CI step to test the packaging, right? Because it contains secrets. |
There are some issues with the manager build and tests as well. Fixing them in #1971. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Let's fix these issues in order to unblock future releases and prevent further breakage.
Manager
Signing of the Windows Server Manager is broken
Command, from macOS:
Packaging of the Manager on Linux and macOS are fine, though it takes a really long time for macOS.
Client
Misplaced environment.json on Client build
The packaging of the Cordova Clients is creating
www/environment.json
in the repo root. Command from macOS:The
www/
directory does not even exist. This is clearly wrong, so packaged apps will misbehave. Probably a missed migration from #1945.Misplaced client icons
I got this when building macOS:
Can we make the build fail in case of missing images?
macOS Client build takes forever
That's because we build for ios, iossimulator, maccatalyst and macos. The builds don't seem to get faster, so it's probably not incremental. We need to investigate how to make it faster.
Both
No packaging test
We should run the packaging step on CI if possible to detect packaging breakage.
The text was updated successfully, but these errors were encountered: