You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
we are restricted to C++17, so to use fmt's compile-time error catching, we must use its FMT_STRING macro, which only accepts literals; as far as I understand, this means we need our own preprocessor macros. Note that things are easier in C++20
I tried writing such preoprocessor macro implementation in fix: catch bad fmt format strings at compile-time #267, but after some testing, it makes some generalized log printing rather difficult, and one-line if / else blocks become a bit dodgy (because of handling semicolons and scopes ({ and }))
We could use a better logging library, but I'm not sure it's a good idea on imposing yet another dependency just for logging; the Logger class exists to avoid another dependency
I'm going to leave this issue open, in case someone has a better idea than #267, or is willing to complete it correctly.
More recent versions of
fmt
can do this, but we may need to re-think howLogger
is implemented, in particular:iguana/src/iguana/services/Logger.h
Lines 119 to 122 in 05347b2
The text was updated successfully, but these errors were encountered: