Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public access to JEvent::Set #155

Closed
DraTeots opened this issue Aug 25, 2022 · 1 comment
Closed

Public access to JEvent::Set #155

DraTeots opened this issue Aug 25, 2022 · 1 comment

Comments

@DraTeots
Copy link
Collaborator

Related to #154

JEvent::Set is publicly open while should only be used for EventSources. Might be very confusing for users that

// in one place
event->Set(...);   // Allowed and OK

// in another place
event->Set(...);   // Allowed but is NOT OK

Here I intentionally use "one place" and "another place" instead of EventSource and Factory because for new users it is "one place" to look and copy code and "another place" to look and copy code.

@nathanwbrei
Copy link
Collaborator

Moving this discussion to #254

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants