Skip to content

Several improving suggestions #4

@NeumoNeumo

Description

@NeumoNeumo

Thanks for your wonderful work! Shinxbot helps me a lot to ease my life and improve my study ability.

However, when reviewing the source code, I found some potential coding improvements for this project:

  1. homodata.txt is actually a data file. Placing it with configuration files in config does not look good to me.
  2. Changing part of shinx_message and resend the message to where it comes is somewhat weird though. Imagine that you receive a message in your mobile phone and you just edit some portion and forward to others.
  3. Since you have implemented a log system yourself, why not use it though out the repo. I noticed that std::cout, std::error was used sometimes.
  4. get_log actually means log_init, setlog is actually writing log. Moreover, get_log and setlog have distinct syntax.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions