Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message#edit should edit the whole messages instead of only the parameter #822

Open
felldo opened this issue Jul 23, 2021 · 2 comments · May be fixed by #977
Open

Message#edit should edit the whole messages instead of only the parameter #822

felldo opened this issue Jul 23, 2021 · 2 comments · May be fixed by #977
Labels
good first issue Good for newcomers 🔨 breaking-change An issue or pull requests that would be a breaking change

Comments

@felldo
Copy link
Member

felldo commented Jul 23, 2021

Currently i.e. Message#edit(String) only updates the message content instead of removing the embed and components. The method should be changed to "replace" the message with the given new content and corresponding new methods i.e. Message#editContent should be added to only update the specific field.
@felldo felldo added 🔨 breaking-change An issue or pull requests that would be a breaking change good first issue Good for newcomers labels Oct 2, 2021
@MatthewMerrill MatthewMerrill mentioned this issue Oct 31, 2021
Open
@felldo felldo added this to the Next Version milestone Jan 28, 2022
@jyp17
Copy link

jyp17 commented Feb 7, 2022

I'd like to take over this issue if that's alright. Should I ask questions concerning the issue here or on the discord?

@felldo
Copy link
Member Author

felldo commented Feb 14, 2022

I'd like to take over this issue if that's alright. Should I ask questions concerning the issue here or on the discord?

If you have general questions our Discord may be a better place to get answers faster.

@jyp17 jyp17 linked a pull request Mar 14, 2022 that will close this issue
Open
@felldo felldo linked a pull request Mar 15, 2022 that will close this issue
Change Message#edit and add editContent and editEmbed methods #977
Open
@Bastian Bastian modified the milestones: Version 3.5.0, Next Version Jun 21, 2022
@Bastian Bastian modified the milestones: 3.6.0, Next Version Oct 16, 2022
@felldo felldo removed this from the Next Version milestone Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers 🔨 breaking-change An issue or pull requests that would be a breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change Message#edit and add editContent and editEmbed methods jyp17/Javacord
3 participants
@Bastian @felldo @jyp17