Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacement/just removal and deprecation of getDiscriminatedName #1245

Open
TheKodeToad opened this issue May 20, 2023 · 8 comments · May be fixed by #1260
Open

Replacement/just removal and deprecation of getDiscriminatedName #1245

TheKodeToad opened this issue May 20, 2023 · 8 comments · May be fixed by #1260
Labels
✨ feature request New feature or request

Comments

@TheKodeToad
Copy link
Contributor

TheKodeToad commented May 20, 2023 •
edited
Loading

What feature are you proposing?

getDiscriminatedName is no longer desirable as users who've migrated to the new username system will have no discriminator (represented as 0). I personally don't think changing the behaviour of the method is a good idea as the name implies that it will have a discriminator!

The method could have a replacement which drops #0... however at some point both getDiscriminatedName and this method will become useless

Do you have any additional material for your feature proposal?

No response
@TheKodeToad TheKodeToad added the ✨ feature request New feature or request label May 20, 2023
@TheKodeToad TheKodeToad changed the title Replacement/just removal and deprecation of getDiscriminatedName Replacement/just removal and deprecation of getDiscriminatedName May 20, 2023
@RealYusufIsmail
Copy link
Contributor

Regarding this, as the user no longer has a discriminator it could be made where getUserName provides you with the @ userName and getGlobalName gets there display Name. getDiscriminatedName should be marked as @deprecated but no removed until bots migrate too

@TheKodeToad
Copy link
Contributor Author

There are still regular users with discriminators

@RealYusufIsmail
Copy link
Contributor

There are still regular users with discriminators

Majority have migrated but I said keep it

@TheKodeToad
Copy link
Contributor Author

You should not deprecate something which should be used imo

@RealYusufIsmail
Copy link
Contributor

You should not deprecate something which should be used imo

but it will be removed in the future.

@RealYusufIsmail RealYusufIsmail linked a pull request Aug 24, 2023 that will close this issue
Open
2 tasks
@RealYusufIsmail
Copy link
Contributor

@TheKodeToad if you wish you can have a look at the pr i made a while back and see if you have any suggestions for amendment.

@TheKodeToad
Copy link
Contributor Author

but it will be removed in the future.

Well, the PR's merge will need to be delayed.

@RealYusufIsmail
Copy link
Contributor

but it will be removed in the future.

Well, the PR's merge will need to be delayed.

why. you need make users aware.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
✨ feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrated to new user name system RealYusufIsmail/Javacord
2 participants
@TheKodeToad @RealYusufIsmail