From c117411c8dad5e53c11e4f36e1bae48c086da090 Mon Sep 17 00:00:00 2001 From: Rian-Ismael <106334437+Rian-Ismael@users.noreply.github.com> Date: Thu, 30 Jan 2025 14:16:17 -0300 Subject: [PATCH] Update OrJanusPredicateTest.java Improves the readability of the test. The assertions are clearer and include descriptive messages, making it easier to identify which assertion fails. This enhances code maintainability, understanding and debugging efficiency. Signed-off-by: Rian-Ismael <106334437+Rian-Ismael@users.noreply.github.com> --- .../graphdb/predicate/OrJanusPredicateTest.java | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/janusgraph-test/src/test/java/org/janusgraph/graphdb/predicate/OrJanusPredicateTest.java b/janusgraph-test/src/test/java/org/janusgraph/graphdb/predicate/OrJanusPredicateTest.java index 2b869d2aea..4b87be0b0f 100644 --- a/janusgraph-test/src/test/java/org/janusgraph/graphdb/predicate/OrJanusPredicateTest.java +++ b/janusgraph-test/src/test/java/org/janusgraph/graphdb/predicate/OrJanusPredicateTest.java @@ -47,8 +47,11 @@ ConnectiveJanusPredicate getNegatePredicate(List childPredi @Test public void testIsQNF() { - assertTrue(getPredicate(Arrays.asList(Text.PREFIX, Cmp.EQUAL)).isQNF()); - assertTrue(getPredicate(Arrays.asList(Text.PREFIX, Cmp.EQUAL, new OrJanusPredicate(Arrays.asList(Text.PREFIX, Cmp.EQUAL)))).isQNF()); - assertFalse(getPredicate(Arrays.asList(Text.PREFIX, Cmp.EQUAL, new AndJanusPredicate(Arrays.asList(Text.PREFIX, Cmp.EQUAL)))).isQNF()); + assertTrue(getPredicate(Arrays.asList(Text.PREFIX, Cmp.EQUAL)).isQNF(), "Single PREFIX EQUAL should be QNF"); + assertTrue(getPredicate(Arrays.asList(Text.PREFIX, Cmp.EQUAL, new OrJanusPredicate(Arrays.asList(Text.PREFIX, Cmp.EQUAL)))).isQNF(), + "PREFIX EQUAL with OR(JANUS(PREFIX EQUAL)) should be QNF"); + assertFalse(getPredicate(Arrays.asList(Text.PREFIX, Cmp.EQUAL, new AndJanusPredicate(Arrays.asList(Text.PREFIX, Cmp.EQUAL)))).isQNF(), + "PREFIX EQUAL with AND(JANUS(PREFIX EQUAL)) should not be QNF"); } +``` }