From 9cfd738715e3b5be9070cca5c401dd7392cf04a9 Mon Sep 17 00:00:00 2001
From: jaimelm <jaimelm@umich.edu>
Date: Thu, 29 Oct 2020 20:42:40 -0400
Subject: [PATCH] refined the code

---
 prod/prod-app/cgi-bin/data_collector.cgi | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/prod/prod-app/cgi-bin/data_collector.cgi b/prod/prod-app/cgi-bin/data_collector.cgi
index fc86d42..92dc5ee 100755
--- a/prod/prod-app/cgi-bin/data_collector.cgi
+++ b/prod/prod-app/cgi-bin/data_collector.cgi
@@ -1,8 +1,5 @@
 #!/usr/bin/perl -ws
-# This cgi script parses the submission.
-
-# Read the DATA_DIR environment variable to construct the path for data files to be written to.
-$datadir =  $ENV{'DATA_DIR'};
+# This cgi script parses Experience Sampler submissions and writes the resulting key/value pairs into a data file for each.
 
 # Get the request method.
 $request_method = $ENV{'REQUEST_METHOD'};
@@ -48,10 +45,15 @@ print "Content-type: text/html", "\n\n";
 print $response_content;
 
 # Construct the data file name.
-my $filename = "participant_${id}_data.csv";
+$filename = "participant_${id}_data.csv";
+
+# Check for the DATA_DIR environment variable. If it exists, use it to construct a full path for data files to be written to. Otherwise, the files are written to the same folder as the script.
 
-# Construct the data file path.
-my $filepath = $datadir . "/" . $filename;
+if(defined $ENV{'DATA_DIR'}) {
+        $filepath = $ENV{'DATA_DIR'} . "/" . $filename;
+} else {
+	$filepath = $filename;
+}	
 
 # Open a file handle to write the data.
 open( OUTFILE, ">>", $filepath) or die $!, "Couldn\'t open outfile for writing!\n";