Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less than 50 bug still exsit in the current version. #19

Open
Symous opened this issue Jun 2, 2017 · 9 comments
Open

Less than 50 bug still exsit in the current version. #19

Symous opened this issue Jun 2, 2017 · 9 comments

Comments

@Symous
Copy link

Symous commented Jun 2, 2017

I use the newest version of the index.js and still encounter the less than 50 bug with Android. and I found that this PR has solved it already #10.

@JackPu
Copy link
Owner

JackPu commented Jun 5, 2017

Let me see. Maybe I should check the platform. This PR results in another bug in ios devices. Let me try it.

@JackPu
Copy link
Owner

JackPu commented Jun 5, 2017

could you paste some pictures? @Symous

@Symous
Copy link
Author

Symous commented Jun 5, 2017

@JackPu in the current version of index.js , if we put 25% to the component , it will show 75% . but if we put 75% to the component it will show 75% as expected. I have modified the code to identify the different platform,now it worked well with Android .But still not tested with iOS.Maybe I will test it with iOS in a few days and do a PR.

@nikolasp
Copy link

nikolasp commented Jul 6, 2017

Hi @JackPu,
I have same problem as you can see on image below

image

This screenshot is taken from ios simulator...

@nikolasp
Copy link

nikolasp commented Jul 6, 2017

I've found issue, just changed this

backgroundColor: this.props.percent < 50 ? this.props.bgcolor : this.props.color,

to

backgroundColor: this.props.color,

and everything is fine. Can someone else check this also?

@genglei01
Copy link

这个问题解决了没,我在ios设备上还是会出现
"react": "16.0.0-alpha.6",
"react-native": "0.44.0",
"react-native-percentage-circle": "^1.0.6",

@ricbermo
Copy link

ricbermo commented Aug 4, 2017

This issue is still present on "react-native-percentage-circle": "^1.0.6",

@xuk3r
Copy link

xuk3r commented Aug 18, 2017

i have solved the issue,you need change these codes:

#line 11
import Platform

#line 96
// rightTransformerDegree = '0deg'; // leftTransformerDegree = -(50-percent) * 3.6 + 'deg';

if (Platform.OS == 'ios') { leftTransformerDegree = '0deg'; rightTransformerDegree = percent * 3.6 + 'deg'; }else{ leftTransformerDegree = '0deg'; rightTransformerDegree = -(50-percent) * 3.6 + 'deg'; }

#line 157
//backgroundColor: this.props.percent < 50 ? this.props.bgcolor : this.props.color,

backgroundColor: Platform.OS == 'ios' ? this.props.color : this.props.percent < 50 ? this.props.bgcolor : this.props.color,

line number maybe is wrong,just search the code :)

2017-09-06 09_18_19

@zhuozp
Copy link

zhuozp commented Aug 22, 2017

@a4101823 it seems not work when a percent likes 30.64

@moret moret mentioned this issue Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants