-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default request settings write to .measurement file twice #100
Labels
bug
Something isn't working
Comments
This isn't a big issue anymore thanks to the migitation, but it should probably be fixed at some point. I see five possible ways to solve this:
|
More information in commit c1921d4 |
tpitkanen
added a commit
that referenced
this issue
Nov 26, 2020
- Renaming ElementSimulations is important, and they don't seem to be affected by #100
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Both
Measurement
andSimulation
write their data to the same.measurement
file. This causes issues when editing request settings because it saves both objects' measurement data (general,Run
,Beam
) to the same file.Run
andBeam
and shared between the defaultMeasurement
andSimulation
, so it doesn't affect actual use much, but the general data is not shared. As a result, the description part of Measurement tab in settings is not saved to a file.Another, more serious issue is that changing the name in Measurement tab leads to
.measurement
file duplication for default settings:Measurement
saves with the new name andSimulation
and saves with the old name. This is migitated with 9b7e3af.Reproduction
Request settings > Measurement > Description
(or name if enabled)Measurement
saves with the correct description, followed bySimulation
overwriting the changes.The text was updated successfully, but these errors were encountered: