Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to use the plugin #66

Open
floscher opened this issue Sep 22, 2017 · 4 comments
Open

Document how to use the plugin #66

floscher opened this issue Sep 22, 2017 · 4 comments

Comments

@floscher
Copy link
Member

It would be great, if there would be more and up to date user documentation of the plugin (e.g. on the Wiki page).
Some things like keyboard shortcuts or the different dialogs should be explained somewhere or the users won't be able to (easily) find them.

@vbombaerts
Copy link

vbombaerts commented Apr 29, 2018

Yes please give more info about the plugin.
What I would like to do : I have shot pictures with an action cam not connected to Mapillary but with GPS capabilities. I want to upload it to Mapillary but before I do that I want to modify location of some images in JOSM. Right now, pictures are stored on my computer. I want to load it to JOSM, modify location and send them to mapillary with the new location.
Can I do that with the plugin ?
How (step by step please) ?
josm_mapillary

@floscher
Copy link
Member Author

floscher commented Apr 29, 2018

Hi @vbombaerts,
here's how you would do that:

  1. Make sure you are logged into your Mapillary account with JOSM (Settings › Display settings › Mapillary, then the green button in the upper right corner)
  2. Load all images that you want to end up in one Mapillary sequence into a "geotagged images" layer like you did
  3. [ Open the Mapillary layer (Shift + ,). This is only necessary in the current version v1.5.12 of the plugin because of a bug I just discovered when trying this out. Future versions won't need this. ]
  4. Click on Import images in the File menu and then on From existing image layer. Select the image layer you want to import to the Mapillary layer.
  5. Activate the Mapillary layer (green checkmark in front of the layer). You can move the images around with Click and drag and rotate them with Shift-click and drag.
  6. When you are ready, start uploading via FileUpload Mapillary images

Hope that already helps, if you can confirm that these steps work out fine, we can put these steps on the wiki page.

floscher referenced this issue Apr 29, 2018
That was an oversight in c8f1ec0. The images were added to the Mapillary layer but the layer was not displayed. You had to open the layer manually, starting with this commit it opens automatically again.

Also, the "Import" button when selecting the "geotagged images" layer is now disabled as long as there are no layers selected.
@vbombaerts
Copy link

vbombaerts commented Apr 30, 2018

@floscher Thanks for your answer. It works great. I did not yet check if pictures are already published on Mapillary.

I would add (at step 6.) that to select all the sequence at once you have to double-click on one picture.

Something else (maybe it is better to open an new issue) :
I did not find how to select a range of pictures at once (click first picture of a range - hold a key - click last picture of a range), e.g. to move them all together. If I'm not wrong, the only way to do this right now is to ctrl-click each picture of the range. It would be great if this process could be speeded up a bit by easy selecting a range of pictures.

Another great tool (but maybe more difficult to implement) would be to be able to rotate a range of pictures. For example to correct the location of the pictures of my example, I would first select a first range of pictures, the one on the right, then rotate to align with the OSM road and shift to put it on the road. For the second range (left), I would only shift it. After those raw relocations, I would adjust one by-one the pictures that still need it.

@floscher
Copy link
Member Author

floscher commented May 1, 2018

@vbombaerts Thank you for reporting back, glad it works. I'll then copy the steps as they are to the wiki, with the addition about double-clicking.

Unfortunately I won't have time to implement new features for the Mapillary plugin in the near future. But if there is someone who wants to develop something new (or add documentation in the wiki) for the plugin I'm always open and ready to support such an effort.

I like the idea to select multiple images in one go, this is definitely missing. My personal preference would be to select by clicking and dragging a rectangle around the images, like you do it with OSM data layers. But your idea also sounds good. Feel free to open an issue for that.

The second tool you suggested (I think) already exists, I can rotate or move multiple images the same way I rotate/shift a single image. Simply select multiple images and try to move/rotate one of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants