Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translatables on Transifex #131

Open
tsmock opened this issue Aug 25, 2020 · 8 comments
Open

Update translatables on Transifex #131

tsmock opened this issue Aug 25, 2020 · 8 comments

Comments

@tsmock
Copy link
Collaborator

tsmock commented Aug 25, 2020

We need to update translatables on transifex.
I know @floscher has access to the JOSM transifex group (https://www.transifex.com/josm/josm/dashboard/), but I don't know about anyone else.

@floscher
Copy link
Member

floscher commented Aug 25, 2020

I can look into it. You want to push new translatable strings to transifex, right? Or update the *.po files with the current state from transifex.com

@tsmock
Copy link
Collaborator Author

tsmock commented Aug 25, 2020

I want to push some new translatable strings to transifex, yes. Thanks for asking. :)

EDIT: I can already update the translations (I just pulled the sr@latin translation). Also, thanks for the quick reply.

@floscher
Copy link
Member

In the .gitlab-ci.yml file there is a job defined that is meant to sync the master branch to transifex for each pushed commit. Unfortunately for some reason it isn't triggered at the moment.

I'll fix that later today, so it can sync again.

@tsmock
Copy link
Collaborator Author

tsmock commented Aug 25, 2020

I saw that when I copied the .gitlab-ci file into the MapWithAI plugin (although I commented it out).

I kind of assumed that you had deliberately stopped running pipelines, but I guess I assumed wrong.

@floscher
Copy link
Member

As far as I can see, the sync to transifex does not happen, because ./gradlew build fails, because the :spotlessJava task finds errors: https://gitlab.com/JOSM/plugin/Mapillary/-/pipelines/158074122

Then the deploy stage does not run. You could make spotlessJava run through even when it found violations, fix the reported violations or exclude that task from the CI jobs build and java 11 build. Then the upload to Transifex should work again.

@tsmock
Copy link
Collaborator Author

tsmock commented Aug 25, 2020

That should be fixed. I just ran it locally -- I also ran gitlab-runner exec docker build for a sanity check, and that succeeded as well.

The pipeline you reference ran two months ago. Since then, only scheduled pipelines have been run. I know there were some changes to mirrored repos in the past few months, so that may have affected the pipeline settings for mirrored repos.

@tsmock
Copy link
Collaborator Author

tsmock commented Aug 28, 2020

@floscher : Just an FYI, I modified the CI to use needs instead of dependencies. I also added Java 14 and 15 jobs. For the next scheduled run, I might try (temporarily) removing the except schedule clauses.

@tsmock
Copy link
Collaborator Author

tsmock commented Dec 16, 2020

CI should now be good as far as running through all the stages. I'd still like to get the JOSM/plugin/Mapillary repository CI running properly again though, so I can readd the except schedule clauses.

Since the official CI isn't running on PRs, I've temporarily created another Gitlab repo that runs CI. It does not run the sonar lint analysis, unfortunately.

Let me know when you have had a chance to look into why the primary Gitlab repo isn't running on every PR (and tag).

Latest pipelines as of 2020-12-16:
JOSM/plugin/Mapillary: https://gitlab.com/JOSM/plugin/Mapillary/-/pipelines/230811087
smocktaylor/Mapillary: https://gitlab.com/smocktaylor/Mapillary/-/pipelines/230897160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants