Skip to content

Commit bf9c5d1

Browse files
committed
Update README for current maintainer
Also, update preferred formatting to conform more closesly with JOSM. This is largely to make it easier to move code from the Mapillary JOSM plugin to JOSM in the future. Signed-off-by: Taylor Smock <[email protected]>
1 parent dd9d3a8 commit bf9c5d1

File tree

6 files changed

+11
-13
lines changed

6 files changed

+11
-13
lines changed

.idea/codeStyles/Project.xml

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

CONTRIBUTING.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,10 @@ All contributions to this repository are licensed under the GNU General Public L
1313
## Code formatting
1414

1515
The following format of source code files is preferred in this repository:
16-
* Indentation with 2 spaces per indentation level
16+
* Indentation with 4 spaces per indentation level
1717
* line endings should be UNIX-style line endings (LF)
1818
* one newline (LF) at the end of the file
1919
* where possible don't make lines longer than 120 characters
2020
* avoid trailing whitespace
21+
22+
For ease of moving code to JOSM, code should be formatted the same way JOSM formats code.

README.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,10 @@ A plugin for showing Mapillary images inside the OpenStreetMap-Editor JOSM.
99

1010
You can both download images from mapillary.com or import them from your harddrive.
1111

12-
Support for uploading images and modifying images on Mapillary-servers is in the works, stay tuned.
13-
1412
For instructions on setting up your local copy of this repository, see [INSTALL.md](INSTALL.md).
1513

1614
Our contribution guidelines can be found in [CONTRIBUTING.md](CONTRIBUTING.md).
1715

18-
* Maintainer: nokutu <[email protected]>
16+
* Maintainer: Taylor Smock <[email protected]>
1917
* License: [GPL v2 or later](./LICENSE.md)
2018
* Feel free to contact me for any bug or suggestion.

build.gradle.kts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -114,16 +114,14 @@ spotless {
114114
target("**/*.gradle", "**.*.md", "**/.gitignore")
115115

116116
trimTrailingWhitespace()
117-
indentWithSpaces(2)
117+
indentWithSpaces(4)
118118
endWithNewline()
119119
}
120120
java {
121-
// Exclude datepicker -- this should eventually become another plugin (needs to be in JOSM plugin svn or the replacement thereof)
122-
targetExclude("src/main/java/org/openstreetmap/josm/plugins/datepicker/**/*")
123121
// Avoid large formatting commits.
124122
ratchetFrom("origin/master")
125123
trimTrailingWhitespace()
126-
indentWithSpaces(2)
124+
indentWithSpaces(4)
127125
endWithNewline()
128126
removeUnusedImports()
129127
eclipse().configFile("config/format/code_format.xml")

config/format/code_format.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,7 @@
220220
<setting id="org.eclipse.jdt.core.formatter.insert_space_after_opening_paren_in_synchronized" value="do not insert"/>
221221
<setting id="org.eclipse.jdt.core.formatter.insert_space_after_comma_in_constructor_declaration_throws" value="insert"/>
222222
<setting id="org.eclipse.jdt.core.formatter.insert_space_after_comma_in_record_components" value="insert"/>
223-
<setting id="org.eclipse.jdt.core.formatter.tabulation.size" value="2"/>
223+
<setting id="org.eclipse.jdt.core.formatter.tabulation.size" value="4"/>
224224
<setting id="org.eclipse.jdt.core.formatter.insert_space_after_bitwise_operator" value="insert"/>
225225
<setting id="org.eclipse.jdt.core.formatter.insert_space_after_comma_in_allocation_expression" value="insert"/>
226226
<setting id="org.eclipse.jdt.core.formatter.insert_space_after_opening_bracket_in_array_reference" value="do not insert"/>

gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
plugin.author=nokutu, floscher <incoming+josm-plugin-mapillary-8564565-issue-@incoming.gitlab.com>
1+
plugin.author=nokutu, floscher, taylor.smock <incoming+josm-plugin-mapillary-8564565-issue-@incoming.gitlab.com>
22
plugin.canloadatruntime=true
33
plugin.class=org.openstreetmap.josm.plugins.mapillary.MapillaryPlugin
44
plugin.description=Allows the user to work with pictures hosted at mapillary.com

0 commit comments

Comments
 (0)