-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for TF 2.16 #2
Comments
optimizer.lr disappeared from the Keras API in TF 2.16 , breaking Uno. This seems to work for TF 2.15 and 2.16 . Should we do it like this or simply refer to params["learning_rate"] ? |
Using params["learning_rate"] directly feels like a more solid and future-proof way to go since it keeps the code in line with newer TensorFlow versions and avoids relying on stuff that’s been removed. What do you think about adding version checks to handle both TensorFlow 2.15 and 2.16? That way, we could switch between optimizer.learning_rate and params["learning_rate"] as needed. |
I'll test out and create a PR and ref. this issue |
Sounds good. |
No description provided.
The text was updated successfully, but these errors were encountered: