-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unpadded variants could avoid using Unsafe #387
Comments
I can clearly provide a PR for such if you wish |
We currently have:
You are effectively suggesting a further package of generated code, maybe To do this we would need to look at the code gen code and generate the code, as well as modify the tests to cover the new variants. This will inflate the jar somewhat, but it's a modest increase to a pretty small jar, and people can alway strip away the extra code if they really care about size. This is doable, but I'm not going to spend time on it :-), please feel free to PR. |
I think you can close this one due to #388 being merged 😄 Could we have a release soon? I'd replace the Unsafe/unpadded queues used in Mutiny, this also would simplify native compilation in Quarkus. |
Fixed in 4.0.4/4.0.5 release |
HI @nitsanw !
Now, for convenience we create the unpadded version of the queues out of the Unsafe-based ones, but actually, if users doesn't care about maximum performance by preventing false-sharing, maybe they are NOT interested either to use Unsafe as well, for the same reason. This would make the adoption of such wider, and life of native-image users, happier, wdyt?
The text was updated successfully, but these errors were encountered: