Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to stop installations (and maybe pause?) #30

Open
ItsSim opened this issue Feb 6, 2022 · 0 comments
Open

Ability to stop installations (and maybe pause?) #30

ItsSim opened this issue Feb 6, 2022 · 0 comments
Labels
feature accepted Feature has been accepted help wanted Extra attention is needed low priority Low priority

Comments

@ItsSim
Copy link
Owner

ItsSim commented Feb 6, 2022

Is your feature request related to a problem? Please describe.
It is very common for installers to allow the user to stop any ongoing installations. Right now, the only way to stop an installation is to exit the launcher completely, but it doesn't happen cleanly.

Describe the solution you'd like
Installations should be stoppable without having to exit the launcher, by adding a stop control. Implementation is up to whoever wants to take care of this issue.

  • Stopped installations should cleanup everything they have started installing (i.e. delete the destination folder, clean up temp folders).
  • This could tie into the Uninstallers #17 issue, since both stopping an installation and uninstalling something should follow similar steps to each other.
  • When stopping an installation, any ongoing process should be aborted. For example: on macOS if the user stops the installation during a .pkg installation for mono, it should stop this process. Another example would be zip extraction, or a download.
  • Stopping a complete installation should be possible as well. Internally, a complete installation is simply a sequential run of every component installer (you can see this in complete-installer.js). When stopping on the complete installation screen, it should stop the current installer that is running and continue no further. It should cleanup every installer run before that, though (except probably standalone installers, such as OpenAL).
  • Have not studied the possibility of adding a pause control in addition to stop, but if the implementer sees it could work then let me know the analysis in a comment to this issue. In my initial planning it seemed very complex...

Describe alternatives you've considered
N/A

Additional context
Screenshot of current installation items where the new control should be added:

Individual installation item:

image

Complete installation screen:

image

@ItsSim ItsSim added low priority Low priority feature request This is a feature request feature accepted Feature has been accepted labels Feb 6, 2022
@ItsSim ItsSim changed the title [Windows, Mac] Ability to stop installations [Windows, Mac] Ability to stop installations (and maybe pause?) Feb 6, 2022
@ItsSim ItsSim removed the feature request This is a feature request label Feb 20, 2022
@ItsSim ItsSim changed the title [Windows, Mac] Ability to stop installations (and maybe pause?) [Windows/Mac] Ability to stop installations (and maybe pause?) May 2, 2023
@ItsSim ItsSim added the help wanted Extra attention is needed label Aug 4, 2023
@ItsSim ItsSim changed the title [Windows/Mac] Ability to stop installations (and maybe pause?) [All platforms] Ability to stop installations (and maybe pause?) Apr 3, 2024
@ItsSim ItsSim changed the title [All platforms] Ability to stop installations (and maybe pause?) Ability to stop installations (and maybe pause?) Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature accepted Feature has been accepted help wanted Extra attention is needed low priority Low priority
Projects
None yet
Development

No branches or pull requests

1 participant