[Benchmark] Include 'mkTermToEvaluate' in 'benchmark-decode' #6667
+9
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effectfully
added
Evaluation
Performance
Benchmarks
No Changelog Required
effectfully
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
/benchmark validation-decode |
2 similar comments
|
/benchmark validation-decode |
|
/benchmark validation-decode |
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'validation-decode' on '1d9a758c1f' (base) and 'a803b77a84' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'validation-decode' on '1d9a758c1f' (base) and 'a803b77a84' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'validation-decode' on '1d9a758c1f' (base) and 'a803b77a84' (PR) Results table
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mkTermToEvaluateis a part of the script preparation phase. It looks rather inefficient (in two different ways) and we don't seem to have any dedicated benchmarks for catching that other thanvalidation-full, but that's too insensitive due to it evaluating the scripts. I really don't believe there's a good reason formkTermToEvaluateto be inefficient, so I think we should include it in the decoding benchmarks.Let's see how much overhead
mkTermToEvaluatecontributes.