Mismatched parameters of CalculateHandToHandAttackDamage used when calling TryGetOverride

[RedRoryOTheGlen]

The delegate that the CalculateHandToHandAttackDamage uses when calling TryGetOverride are different from its own.

This results in formula overrides being removed during gameplay as they do not have the same signature as the delegate, even if they are exactly the same as the base formula.

[KABoissonneault]

Are you saying that CalculateHandToHandAttackDamage is currently impossible for mods to use because of this?

[RedRoryOTheGlen]

I found a workaround where the override formula has params that match the passed signature by removing the bool player param

Just replace any call for the bool with a check if the attacker is the player. It somehow works without a problem.

Otherwise, even if the override was exactly the same as the vanilla formula, it will throw the exception.

[KABoissonneault]

Yeah unfortunately at this stage I'm tempted to keep it. It's unintuitive, but if you can get it working, it's better to assume someone is already relying on this signature.