City Watch enemies causing significant performance issues

[RedRoryOTheGlen]

When there are many City Watch enemies present and hunting the player, performance will significantly decrease.

This seems to be caused by each individual City Watch enemy's EnemySounds.IsReady() repeatedly calling dfAudioSource.GetAudioClip() twice every Fixed Update due to the City Watch having their Move Sound and Attack Sound variables set to SoundClips.None. Changing these values to SoundClips.EnemyMove or EnemyAttack either in EnemyBasics or through a mod accessing the static EnemyBasics.Enemies array results in a massive performance boost even when there are numerous City Watch engaging the player.

[KABoissonneault]

Have you measured this issue with a game build? If you enable Development Build when creating a game build from the Editor, you can then play a normal game with profiling enabled (which you run from the editor but remotely connected to your game client).

I'm saying this because the editor has much, much worse performance on file access than the game itself. The editor loads from disk each time, while the game loads those files ahead of time.

I've observed a few times in the past people trying to rewrite everything for something that only affects the editor.

I'm not against a simple fix if it can make the editor better, but it's not as much of a priority.

[RedRoryOTheGlen]

True enough. It definitely seems to be negligible in the standalone build. I've only noticed it happening in the editor because I usually avoid aggro'ing guards on my main install. Meanwhile I frequently get halt trains in the editor when testing stuff. I guess it's all good since I've already mitigated it on my end.

Thanks for your time!