Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last dfmod support for 1.2 #2655

Open
KABoissonneault opened this issue May 20, 2024 · 1 comment
Open

Last dfmod support for 1.2 #2655

KABoissonneault opened this issue May 20, 2024 · 1 comment
Labels
mod system An issue or a request related to mods development.
Milestone

Comments

@KABoissonneault
Copy link
Collaborator

I'm making one issue for a list of all modding features that still only support "loose files" and not .dfmod. I'd like to clear them completely for 1.2. Feel free to add features in a reply below.

  • BIOGs (for localization)
  • Namegen.txt
@KABoissonneault KABoissonneault added the mod system An issue or a request related to mods development. label May 20, 2024
@KABoissonneault KABoissonneault added this to the DFU 1.2 milestone May 20, 2024
@KABoissonneault
Copy link
Collaborator Author

KABoissonneault commented Jun 22, 2024

I can't pinpoint exactly where yet, but the XMLManager is pretty still loose file minded.
Functions like XMLManager.XmlFileExists and the path-based constructor only support loose files, making some systems only work with loose files. We should probably rework all of those to use the package-friendly XMLManager.TryReadXml

We have a mod having issues with crosshair replacement, for example. HUDCrosshair uses DaggerfallUI.GetTextureFromResources, which uses TextureReplacement.TryGetSize, which uses XMLManager.XmlFileExists, which only supports loose files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod system An issue or a request related to mods development.
Projects
None yet
Development

No branches or pull requests

1 participant