[ALL] Add a pre-commit default configuration (#81)

Author: Gaspi

.github/workflows/release.yml

@@ -27,7 +27,7 @@ jobs:
         uses: azure/setup-helm@v4
         with:
           version: v3.10.0
-          
+
       - name: Install helm-docs
         run: |
           cd /tmp

.pre-commit-config.yaml

@@ -0,0 +1,40 @@
+repos:
+- repo: https://github.com/Gaspi/pre-commit-hooks
+  rev: v0.3
+  hooks:
+  # Validate schemas using the jsonschema.validators package
+  - id: validate-json-schemas
+    args:
+    # Forbid legacy https://json-schema.org/draft/2020-12/schema schema validator and suggest Draft 7 instead
+    - --forbid-legacy
+  # Ensure technically facultative attribute (such as `type`) are systematically specified
+  - id: missing-attributes-schemas
+    args:
+    # Also require `items` to be systematically specified for arrays
+    - --check-items
+    # Also require `properties` to be systematically specified for object
+    - --check-properties
+    # Also require `properties` to be systematically specified for object
+    - --check-defaults
+  - id: version-bump
+    args:
+    - --branch
+    - main
+
+- repo: https://github.com/pre-commit/pre-commit-hooks
+  rev: v5.0.0
+  hooks:
+  # Check yaml files except for Helm templates
+  - id: check-yaml
+    exclude: "/(templates|tests)/"
+  # Check empty new line before EOF (ignore generated charts)
+  - id: end-of-file-fixer
+  # Check trailing whitespaces (ignore generated charts)
+  - id: trailing-whitespace
+
+# Run `helm lint` on all (modified) charts: this may require a manual `helm dep update`:
+# ls charts | xargs -i{} bash -c "cd charts/{} && helm dep update"
+- repo: https://github.com/gruntwork-io/pre-commit
+  rev: v0.1.15
+  hooks:
+  - id: helmlint

README.md

@@ -1,7 +1,7 @@
 # Helm charts Automation
 
 This collection of Helm Charts is tailored for datascientists !
-It is primarly designed to work with [Onyxia](https://github.com/inseefrlab/onyxia) but also works as a standalone Helm repository.  
+It is primarly designed to work with [Onyxia](https://github.com/inseefrlab/onyxia) but also works as a standalone Helm repository.
 You should use official helm repository of each opensource software if you don't use onyxia.
 
 :warning: If you intend to use `argo-cd` or `argo-workflows` from this repo, you first have to install and upgrade CRDs manually as it has been disabled here (installing CRDs multiple times fails with error `Error: rendered manifests contain a resource that already exists. Unable to continue with install: CustomResourceDefinition "applications.argoproj.io" in namespace "" exists and cannot be imported into the current release: invalid ownership metadata; label validation error: missing key "app.kubernetes.io/managed-by": must be set to "Helm"; annotation validation error: missing key "meta.helm.sh/release-name": must be set to "argo-cd-446848"; annotation validation error: missing key "meta.helm.sh/release-namespace": must be set to "user-xxx"`). See https://github.com/argoproj/argo-helm/tree/main/charts/argo-cd#custom-resource-definitions for more details. :warning:

charts/airflow/Chart.yaml

@@ -11,7 +11,7 @@ home: https://airflow.apache.org/
 sources:
   - https://github.com/bitnami/charts/tree/main/bitnami/airflow
 type: application
-version: 0.0.1
+version: 0.0.2
 appVersion: "2.10.3"
 dependencies:
 - name: airflow

charts/airflow/values.schema.json

@@ -190,6 +190,7 @@
             "repositories": {
               "description": "List of git repositories to synchronize DAGs with",
               "type": "array",
+              "default": [],
               "items": {
                 "type": "object",
                 "properties": {
@@ -377,8 +378,12 @@
               }
             },
             "from": {
+              "description": "Array of sources allowed to have network access to your service",
               "type": "array",
-              "description": "Array of source allowed to have network access to your service",
+              "items": {
+                "type": "object",
+                "additionalProperties": true
+              },
               "default": [],
               "x-onyxia": {
                 "hidden": true,
@@ -405,4 +410,4 @@
       }
     }
   }
-}
+}

charts/argilla/Chart.yaml

@@ -12,7 +12,7 @@ sources:
   - https://github.com/InseeFrLab/helm-charts-miscellaneous/tree/master/charts/argilla
   - https://github.com/argilla-io/argilla/
 type: application
-version: 1.0.1
+version: 1.0.2
 appVersion: "2.3.0"
 dependencies:
 - name: redis

charts/argilla/templates/hpa.yaml

@@ -20,4 +20,4 @@ spec:
       target:
         type: Utilization
         averageUtilization: 80
-{{ end }}
+{{ end }}

charts/argilla/templates/ingress.yaml

@@ -29,6 +29,6 @@ spec:
             backend:
               service:
                 name: {{ include "library-chart.fullname" . }}
-                port: 
+                port:
                   number: 6900
-{{- end }}
+{{- end }}

charts/argilla/values.schema.json

@@ -773,8 +773,12 @@
               }
             },
             "from": {
+              "description": "Array of sources allowed to have network access to your service",
               "type": "array",
-              "description": "Array of source allowed to have network access to your service",
+              "items": {
+                "type": "object",
+                "additionalProperties": true
+              },
               "default": [],
               "x-onyxia": {
                 "hidden": true,

charts/argo-cd/Chart.yaml

@@ -24,7 +24,7 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 1.0.2
+version: 1.0.3
 
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application. Versions are not expected to