Skip to content

Handle devices with multiple interfaces properly #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pixup1 opened this issue Mar 10, 2025 · 0 comments
Open

Handle devices with multiple interfaces properly #64

pixup1 opened this issue Mar 10, 2025 · 0 comments
Labels
Back backend thing Front frontend thing Netcontrol Netcontrol thing Priority: medium

Comments

@pixup1
Copy link
Member

pixup1 commented Mar 10, 2025

This is an issue that appears most often when someone is using Wi-Fi and wired connections at the same time. A device with two (or more) interfaces has two (or more) MAC addresses and IPs. But it only has one browser and only sends one login request, which will only authenticate one of the interfaces.

This can be fine but if the user decides to unplug their cable thinking they can rely on Wi-Fi (or vice-versa) they can get stuck in a state where their browser thinks they are logged in and netcontrol denies them access to the network.

Then, they might try to log out and back in (unlikely), but even then they couldn't log out since netcontrol would throw an nftables error from trying to remove an item from a set in which it isn't.

I'm sure this can lead to other weird states which I haven't thought about.

I have no idea how to solve this issue (no way a website can access physical interface data, or even IPs that aren't being routed through). Maybe it would be worth looking into how other captive portals deal with this.

(Maybe don't use cookies ? idk that sounds insane)

@pixup1 pixup1 added Back backend thing bug Front frontend thing Netcontrol Netcontrol thing Priority: medium labels Mar 10, 2025
@pixup1 pixup1 removed the bug label Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Back backend thing Front frontend thing Netcontrol Netcontrol thing Priority: medium
Projects
None yet
Development

No branches or pull requests

1 participant