Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] 200% pixel models are very small and far away #38

Open
2 tasks done
Grat10borg opened this issue May 26, 2023 · 1 comment
Open
2 tasks done

[BUG] 200% pixel models are very small and far away #38

Grat10borg opened this issue May 26, 2023 · 1 comment
Labels
Bug Something isn't working
Milestone

Comments

@Grat10borg
Copy link

Grat10borg commented May 26, 2023

Validations

  • I have checked for similar bug reports and could not find any.
  • I have tested and confirmed that this is an issue in an official branded build.

Describe the bug

importing a pixelmodel only resized by 200% makes it extremely small in session even though it looks fine on creator

image

Reproduction

  1. start inochi session
  2. drag inp file of a small 200% resolution model

System Architecture

None

Operating System

Windows

Version

8.0

Logs

No response

Additional Context

No response

@Grat10borg Grat10borg added Bug Something isn't working Triage PR/Issue needs to be triaged. labels May 26, 2023
@ExpiredPopsicle ExpiredPopsicle removed the Triage PR/Issue needs to be triaged. label Jun 11, 2023
@ExpiredPopsicle ExpiredPopsicle added this to the 0.9 milestone Jun 11, 2023
@prettykool
Copy link

I haven't tested this (all attempts to compile kept failing), but this may/may not help. This doubles the max value of the scaling - Probably overkill for most people, if I'm being honest.

diff --git a/source/session/scene/package.d b/source/session/scene/package.d
index 37ef86f..71958e4 100644
--- a/source/session/scene/package.d
+++ b/source/session/scene/package.d 
@@ -426,7 +426,7 @@ void insInteractWithScene() {
         targetScale = clamp(
             targetScale+targetDelta, 
             0.25,
-            5
+            10
         );
         
         if (targetScale != prevScale) {
@@ -492,7 +492,7 @@ void insInteractWithScene() {
             targetScale = clamp(
                 targetScale+targetDelta, 
                 0.25,
-                5
+                10
             );
         }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

3 participants