Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Crash after exporting video and leaving Creator idle for a few minutes. #392

Open
2 tasks done
fossphur opened this issue Sep 3, 2024 · 5 comments
Open
2 tasks done
Labels
Bug Something isn't working Triage PR/Issue needs to be triaged.

Comments

@fossphur
Copy link

fossphur commented Sep 3, 2024

Validations

  • I have checked for similar bug reports and could not find any.
  • I have tested and confirmed that this is an issue in an official branded build.

Describe the bug

I am exporting a video (default settings) of a simple animation, and then leaving the application idle in the Animation Editor with the animation playing. I would not expect anything to happen, but what happens is after a few minutes Inochi creator crashes. After the first crash I tried exporting the same animation again and leaving the application idle, and I was able to reproduce the crash again after a short time.

Reproduction

  1. Have a puppet set up with an animation
  2. Place a camera in the puppet node and resize it to more closely fit the puppet
  3. Go to Animation Editor
  4. Play the Animation (unknown whether this is relevant, it was just something I did when this crash occurred)
  5. Click File > Export > Video
  6. Choose a file name (in this case throw1.mp4)
  7. Export the video
  8. Due to the known issue where the video file does not close, repeat Step 5 and 6 and choose a different file name (in this case throw2.mp4)
  9. Export the second video
  10. Leave the application idle while thinking about something else
  11. Creator crashes and creates a crashdump text file on the desktop

System Architecture

x86_64

Operating System

Windows

Version

v0.8.5

Logs

Click to expand! First Crash ``` === Args State ===

=== Exception ===
std.file.FileException@std\file.d(885): C:\Users\Bronwen\AppData\Roaming.inochi-creator\autosaves\throw2.mp4 del\creator-project.lock: Access is denied.

0x00007FF6B8E16F33 in ImGuiInputTextState_GetSelectionStart
0x00007FF6B8E16C64 in ImGuiInputTextState_GetSelectionStart
0x00007FF6B8E1677D in ImGuiInputTextState_GetSelectionStart
0x00007FF6B8E0A3E1 in ImGuiInputTextState_GetSelectionStart
0x00007FF6B8DF7BDE in ImGuiInputTextState_GetSelectionStart
0x00007FF6B8DBED30 in pure nothrow @nogc @safe mir.numeric.mir_find_root_result!(real).mir_find_root_result mir.numeric.findRootImpl(real, real, real, real, real, real, uint, uint, scope real delegate(real) pure nothrow @nogc @safe, scope bool delegate(real, real) pure nothrow @nogc @safe)
0x00007FF6B8CAB1F3 in igImAbs_Float
0x00007FF6B8CD2CC9 in igImAbs_Float
0x00007FF6B8CD26DA in igImAbs_Float
0x00007FF6B8CD23F3 in igImAbs_Float
0x00007FF6B8D2D30A in ImGuiDockNode_IsSplitNode
0x00007FF6B8D2D1C1 in ImGuiDockNode_IsSplitNode
0x00007FF6B8DFEAC5 in ImGuiInputTextState_GetSelectionStart
0x00007FF6B8DFE77B in ImGuiInputTextState_GetSelectionStart
0x00007FF6B8DFEA26 in ImGuiInputTextState_GetSelectionStart
0x00007FF6B8EBAED0 in ImGui_ImplOpenGL3_Shutdown
0x00007FF87EA77374 in BaseThreadInitThunk
0x00007FF87F1FCC91 in RtlUserThreadStart

</details>


<details>
<summary>Click to expand! Second crash caused intentionally</summary>

=== Args State ===

=== Exception ===
std.file.FileException@std\file.d(885): C:\Users\Bronwen\AppData\Roaming.inochi-creator\autosaves\throw4 e model\creator-project.lock: Access is denied.

0x00007FF6B8E16F33 in ImGuiInputTextState_GetSelectionStart
0x00007FF6B8E16C64 in ImGuiInputTextState_GetSelectionStart
0x00007FF6B8E1677D in ImGuiInputTextState_GetSelectionStart
0x00007FF6B8E0A3E1 in ImGuiInputTextState_GetSelectionStart
0x00007FF6B8DF7BDE in ImGuiInputTextState_GetSelectionStart
0x00007FF6B8DBED30 in pure nothrow @nogc @safe mir.numeric.mir_find_root_result!(real).mir_find_root_result mir.numeric.findRootImpl(real, real, real, real, real, real, uint, uint, scope real delegate(real) pure nothrow @nogc @safe, scope bool delegate(real, real) pure nothrow @nogc @safe)
0x00007FF6B8CAB1F3 in igImAbs_Float
0x00007FF6B8CD2CC9 in igImAbs_Float
0x00007FF6B8CD26DA in igImAbs_Float
0x00007FF6B8CD23F3 in igImAbs_Float
0x00007FF6B8D2D30A in ImGuiDockNode_IsSplitNode
0x00007FF6B8D2D1C1 in ImGuiDockNode_IsSplitNode
0x00007FF6B8DFEAC5 in ImGuiInputTextState_GetSelectionStart
0x00007FF6B8DFE77B in ImGuiInputTextState_GetSelectionStart
0x00007FF6B8DFEA26 in ImGuiInputTextState_GetSelectionStart
0x00007FF6B8EBAED0 in ImGui_ImplOpenGL3_Shutdown
0x00007FF87EA77374 in BaseThreadInitThunk
0x00007FF87F1FCC91 in RtlUserThreadStart

</details>
<details>
<summary>Click to expand!</summary>

// paste the log text here

</details>

### Additional Context

I think the crash has something to do with Autosaves, I'm set to 3 autosaves maximum and I cannot seem to get a third crash to happen. The log is showing the video export's file name instead of the model's file name and that doesn't look right!

With this in mind I searched bug reports again and I think it's similar to #378 - sorry if it's a duplicate but I thought it was interesting that the other issue affects texture.png and my crash affects videoexport.mp4, using the wrong name sometimes for some reason since I do have 3 correctly named autosaves for this model.

Additionally, notepad++ shows [NUL] in the crashdump path which I wasn't able to copy/paste as text above. I'm assuming its a special character and I am not sure if it belongs, since in the second crash dump it overwrote the affected file name.
![crashdump](https://github.com/user-attachments/assets/551b2ad4-ed24-4d3a-948a-cb05f74d3358)
@fossphur fossphur added Bug Something isn't working Triage PR/Issue needs to be triaged. labels Sep 3, 2024
@fossphur
Copy link
Author

fossphur commented Sep 3, 2024

https://github.com/user-attachments/assets/551b2ad4-ed24-4d3a-948a-cb05f74d3358
Somehow trying to add two crashdumps at once messed up the formatting so I'm pasting the pic of the file here again to hopefully more clearly show the [NUL] in the file

@r888800009
Copy link
Contributor

Duplicate of #378

@fossphur
Copy link
Author

fossphur commented Sep 3, 2024

explorer_14kTsLvxbG

More info for replication:
If I save a file or export another file that does not have the same name as the model.inx before any autosaves are created, the autosave process seems to use that filename to try to create the autosave. For example I made a new model called lookingforcrash.inx and saved it and then I exported a video called lookingforcrash2.mp4 and after the 5 mins for an autosave to kick in, Creator crashed. I now have an empty folder called lookingforcrash2.mp4 in the autosaves folder. I do not have a folder at all for the lookingforcrash model, as I would have expected so there is no creator-project.lock (of course not because it crashed, the folder was created when I opened the model again).

std.file.FileException@std\file.d(885): C:\Users\Bronwen\AppData\Roaming.inochi-creator\autosaves\lookingforcrash2.mp4 [NUL] kingforcrash\creator-project.lock: Access is denied.

Same null character in the crash dump log too.

@fossphur
Copy link
Author

fossphur commented Sep 3, 2024

Even more info which I think is related.
I went back to working on a model, did some rigging, imported it back into the model in creator, then pressed Save.
filename weirdness
I noticed the confirmation message at the bottom had concatented the puppet file name to the model name. See first picture attached. Also note, there's a weird character in the incorrect filename.

I then pressed save as to try and save the correct filename as I realised this looked wrong, the pre-filled file name was set up to use the puppet file name that I'd just imported from including the .inp file type, rather than the model name and .inx file type.

more filename weirdness

It seems like the active filenames are being wrongly stored/used in the wrong context.

@r888800009
Copy link
Contributor

This should be fixed in the nightly build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Triage PR/Issue needs to be triaged.
Projects
None yet
Development

No branches or pull requests

2 participants