Skip to content

Commit d187d0c

Browse files
committed
Merge branch 'develop'
* develop: specify next release check the password is compatible with the user mention the property removal in the changelog remove the password being stored inside a string property
2 parents 560d67b + 522c10b commit d187d0c

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
# Changelog
22

3+
## 4.3.2 - 2024-10-26
4+
5+
### Fixed
6+
7+
- The password was still being visible inside the `Innmind\Url\Authority\UserInformation::$string` property. The property has been removed.
8+
39
## 4.3.1 - 2024-10-19
410

511
### Changed

src/Authority/UserInformation.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,13 @@ final class UserInformation
1515
{
1616
private User $user;
1717
private Password $password;
18-
private string $string;
1918

2019
private function __construct(User $user, Password $password)
2120
{
21+
// Make sure a user is specified when a password is specified
22+
$password->format($user);
2223
$this->user = $user;
2324
$this->password = $password;
24-
$this->string = $password->format($user);
2525
}
2626

2727
/**
@@ -86,6 +86,6 @@ public function format(Host $host): string
8686

8787
public function toString(): string
8888
{
89-
return $this->string;
89+
return $this->password->format($this->user);
9090
}
9191
}

0 commit comments

Comments
 (0)