Merge pull request #12 from InjectiveLabs/f/named-timer

feat: export combine and add pairs helpers

Author: hmoragrega

metrics.go

@@ -293,7 +293,7 @@ func MergeTags(original Tags, src ...Tags) Tags {
 	return dst
 }
 
-func addPairs(t Tags, tags ...interface{}) Tags {
+func AddPairs(t Tags, tags ...interface{}) Tags {
 	if t == nil {
 		t = make(Tags)
 	}
@@ -321,7 +321,7 @@ func addPairs(t Tags, tags ...interface{}) Tags {
 	return t
 }
 
-func combineAny(tags ...interface{}) Tags {
+func Combine(tags ...interface{}) Tags {
 	tt := make(Tags)
 	var pairs []interface{}
 	for _, x := range tags {
@@ -334,11 +334,11 @@ func combineAny(tags ...interface{}) Tags {
 			pairs = append(pairs, v)
 		}
 	}
-	return addPairs(tt, pairs...)
+	return AddPairs(tt, pairs...)
 }
 
 func (t Tags) AddPairs(tags ...interface{}) Tags {
-	return addPairs(t, tags...)
+	return AddPairs(t, tags...)
 }
 
 func (t Tags) With(k, v string) Tags {

metrics_test.go

@@ -191,6 +191,65 @@ func TestIncr(t *testing.T) {
 	})
 }
 
+func TestAddPairs(t *testing.T) {
+	tests := []struct {
+		name     string
+		initial  Tags
+		input    []interface{}
+		expected Tags
+	}{
+		{
+			name:     "empty tags",
+			initial:  nil,
+			input:    []interface{}{},
+			expected: Tags{},
+		},
+		{
+			name:     "single pair",
+			initial:  nil,
+			input:    []interface{}{"key", "value"},
+			expected: Tags{"key": "value"},
+		},
+		{
+			name:     "multiple pairs",
+			initial:  nil,
+			input:    []interface{}{"key1", "value1", "key2", "value2"},
+			expected: Tags{"key1": "value1", "key2": "value2"},
+		},
+		{
+			name:     "uneven tags",
+			initial:  nil,
+			input:    []interface{}{"key1", "value1", "key2"},
+			expected: Tags{"key1": "value1"},
+		},
+		{
+			name:     "nil value",
+			initial:  nil,
+			input:    []interface{}{"key1", nil},
+			expected: Tags{"key1": "nil"},
+		},
+		{
+			name:     "unsupported type",
+			initial:  nil,
+			input:    []interface{}{"key1", struct{}{}},
+			expected: Tags{},
+		},
+		{
+			name:     "merge with existing tags",
+			initial:  Tags{"existingKey": "existingValue"},
+			input:    []interface{}{"key1", "value1"},
+			expected: Tags{"existingKey": "existingValue", "key1": "value1"},
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			result := AddPairs(tt.initial, tt.input...)
+			assert.Equal(t, tt.expected, result)
+		})
+	}
+}
+
 func TestGauge(t *testing.T) {
 	expectedTags := []string{"foo=bar", "baz=qux"}
 	assertSameResults := func(t *testing.T, rec *statterRecorder) {

reports.go

@@ -46,17 +46,17 @@ func IndexPriceUpdatesBatchSubmitted(size int, tags ...Tags) {
 func Counter[T constraints.Integer](metric string, value T, tags ...interface{}) {
 	CustomReport(func(s Statter, tagSpec []string) {
 		s.Count(metric, int64(value), tagSpec, 1)
-	}, combineAny(tags...))
+	}, Combine(tags...))
 }
 
 func CounterPositive[T constraints.Integer](metric string, value T, tags ...interface{}) {
 	if value > 0 {
-		Counter(metric, value, combineAny(tags...))
+		Counter(metric, value, Combine(tags...))
 	}
 }
 
 func Incr(metric string, tags ...interface{}) {
-	Counter(metric, 1, combineAny(tags...))
+	Counter(metric, 1, Combine(tags...))
 }
 
 func Timer(metric string, value time.Duration, tags ...Tags) {
@@ -68,9 +68,9 @@ func Timer(metric string, value time.Duration, tags ...Tags) {
 // Timing supports both Tags or pairs of key-value arguments.
 func Timing(metric string, initialTags ...interface{}) func(deferredTags ...interface{}) {
 	start := time.Now()
-	it := combineAny(initialTags...)
+	it := Combine(initialTags...)
 	return func(deferredTags ...interface{}) {
-		dt := combineAny(deferredTags...)
+		dt := Combine(deferredTags...)
 		Timer(metric, time.Since(start), MergeTags(it, dt))
 	}
 }
@@ -92,7 +92,7 @@ func TimingCtxWithErr(_ context.Context, metric string, initialTags ...interface
 func Gauge(metric string, value float64, tags ...interface{}) {
 	CustomReport(func(s Statter, tagSpec []string) {
 		s.Gauge(metric, value, tagSpec, 1)
-	}, combineAny(tags...))
+	}, Combine(tags...))
 }
 
 func BoolTag(b bool) string {