Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI DFU upload fails on PRs based on branches with / in them #2126

Closed
1 task done
NeroBurner opened this issue Sep 20, 2024 · 1 comment
Closed
1 task done

CI DFU upload fails on PRs based on branches with / in them #2126

NeroBurner opened this issue Sep 20, 2024 · 1 comment

Comments

@NeroBurner
Copy link
Contributor

Verification

  • I searched for similar issues (including closed issues) and found none was relevant.

Introduce the issue

The Upload DFU artifacts job fails on branches containing /

Found in #2077

Run actions/upload-artifact@v3
/usr/bin/docker exec  8929a36ab468da80dae43387a0c9bb4bf9dcabe29646a93654a36d48575c83ed sh -c "cat /etc/*release | grep ^ID"
With the provided path, there will be 3 files uploaded
Starting artifact upload
For more detailed logs during the artifact upload process, enable step-debugging: https://docs.github.com/actions/monitoring-and-troubleshooting-workflows/enabling-debug-logging#enabling-step-debug-logging
Error: Artifact name is not valid: InfiniTime DFU fix/eol-on-windows. Contains the following character:  Forward slash /
          
Invalid characters include:  Double quote ", Colon :, Less than <, Greater than >, Vertical bar |, Asterisk *, Question mark ?, Carriage return \r, Line feed \n, Backslash \, Forward slash /
          
These characters are not allowed in the artifact name due to limitations with certain file systems such as NTFS. To maintain file system agnostic behavior, these characters are intentionally not allowed to prevent potential problems with downloads on different file systems.

Preferred solution

update actions/upload-artifact@v3 or somehow replace the invalid characters with _ or something like that

Version

main

@mark9064
Copy link
Member

Resolved by #2166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants