Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCC >= 10 is now required #1957

Open
1 task done
grnmeira opened this issue Jan 7, 2024 · 1 comment
Open
1 task done

GCC >= 10 is now required #1957

grnmeira opened this issue Jan 7, 2024 · 1 comment

Comments

@grnmeira
Copy link

grnmeira commented Jan 7, 2024

Verification

  • I searched for similar issues (including closed issues) and found none was relevant.

Introduce the issue

I was compiling InfiniSim (and InfiniTime) on an Ubuntu 20.04 (WSL), which comes with GCC 8 if I'm not mistaken, and ran into a couple of issues with C++20 support. Tried GCC 9 too but kept having the same problem.

This commit introduces the use of consteval (C+++20), but that's only supported by GCC10 onwards.

Preferred solution

It'd be a good idea to make that assumption explicit in the CMake configurations. I'd be happy to place a PR for that if contributions are welcome.

Version

fc5424c@main

@JF002
Copy link
Collaborator

JF002 commented Jan 9, 2024

The documentation mentions the version of GCC (10.3) we support for building InfiniTime. This version is also integrated in the Docker build image.

But yeah, we can add a check in in CMake files. PRs are welcome (but it might take some time for us to review it, depending on our free time available :) ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants