Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning that std::chrono::system_clock is not supported on hardware even though it may work fine in the sim #92

Open
kestara opened this issue Mar 1, 2023 · 5 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@kestara
Copy link

kestara commented Mar 1, 2023

(This confusion has happened at least two times link 1 link 2)

Idea: If use of std::chrono::system_clock is detected (unsure how) then add a warning in the console that on the watch this will result in undefined behaviour.

@kestara kestara changed the title Add warning that std::chrono::system_clock is not supported on hardware even though it may work fine in the sim Add warning that std::chrono::system_clock is not supported on hardware even though it may work fine in the sim label:enhancement Mar 1, 2023
@kestara kestara changed the title Add warning that std::chrono::system_clock is not supported on hardware even though it may work fine in the sim label:enhancement Add warning that std::chrono::system_clock is not supported on hardware even though it may work fine in the sim Mar 1, 2023
@NeroBurner NeroBurner added enhancement New feature or request help wanted Extra attention is needed labels Mar 1, 2023
@NeroBurner
Copy link
Collaborator

I very much like the idea, but sadly I don't know how to pull it off.

@lmamane
Copy link

lmamane commented Oct 27, 2024

Here's a proof of concept. Works on GNU/Linux with gcc at least, other platforms to be tested.

stdchrono_abort.diff.txt

@NeroBurner
Copy link
Collaborator

That looks interesting to say the least! Could you open a PR with those changes for easier workflow on my side and attribution for your work? 🙇‍♂️

@lmamane
Copy link

lmamane commented Oct 31, 2024

Yes, sure. I'll polish it it up and make a PR out of it. I'm prioritising finishing the app I'm developing first, then hopefully I'll get back to that. It is going nicely :)

Nice to see you are interested and responsive.

@lmamane
Copy link

lmamane commented Nov 9, 2024

Assuming my pull request #2162 in InfiniTime is merged, this will become moot and can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants