HA: Limit max open database connections to 1

yhabteab · lippserd · commit ce3309f0c9a8 · 2024-12-17T16:55:29.000+01:00
Previously, the HA feature was allowed to open `max_connections`
database connection in parallel to other Icinga DB components. Meaning,
Icinga DB wasn't limited to the configured `max_connections`, but
effectively to `2 * max_connections`.
diff --git a/cmd/icingadb/main.go b/cmd/icingadb/main.go
@@ -114,6 +114,7 @@ func run() int {
 			logger.Fatalf("%+v", errors.Wrap(err, "can't create database connection pool from config"))
 		}
 		defer func() { _ = db.Close() }()
+		db.SetMaxOpenConns(1)
 		ha = icingadb.NewHA(ctx, db, heartbeat, logs.GetChildLogger("high-availability"))
 
 		telemetryLogger := logs.GetChildLogger("telemetry")

Original file line number	Diff line number	Diff line change
`@@ -114,6 +114,7 @@ func run() int {`
`114`	`114`	`logger.Fatalf("%+v", errors.Wrap(err, "can't create database connection pool from config"))`
`115`	`115`	`}`
`116`	`116`	`defer func() { _ = db.Close() }()`
	`117`	`+ db.SetMaxOpenConns(1)`
`117`	`118`	`ha = icingadb.NewHA(ctx, db, heartbeat, logs.GetChildLogger("high-availability"))`
`118`	`119`
`119`	`120`	`telemetryLogger := logs.GetChildLogger("telemetry")`