ObjectSuggestions: Make CustomVar suggestion sources adjustable

application/controllers/RedundancygroupController.php

@@ -47,7 +47,7 @@
             $groupId = $this->params->shiftRequired('id');
         }
 
         $this->groupId = $groupId;
     }
 
     /**
@@ -61,7 +61,7 @@
 
         $this->applyRestrictions($query);
 
         $this->group = $query->first();
 
         if ($this->group === null) {
             $this->httpNotFound($this->translate('Redundancy Group not found'));
@@ -75,9 +75,9 @@
 
         $this->applyRestrictions($summary);
 
         $this->groupSummary = $summary->first();
 
         $this->addControl(new RedundancyGroupHeader($this->group, $this->groupSummary));
     }
 
     public function indexAction(): void
@@ -186,7 +186,7 @@
 
         $searchBar->getSuggestionUrl()->setParam('isChildrenTab');
         $searchBar->getEditorUrl()
             ->setParams((clone $searchBar->getEditorUrl()->getParams())->set('isChildrenTab', true));
 
         if ($searchBar->hasBeenSent() && ! $searchBar->isValid()) {
             if ($searchBar->hasBeenSubmitted()) {
@@ -228,6 +228,7 @@
         $suggestions = (new ObjectSuggestions())
             ->setModel(DependencyNode::class)
             ->setBaseFilter(Filter::equal("$column.redundancy_group.id", $this->groupId))
+            ->onlyWithCustomVarSources(['host', 'service', 'hostgroup', 'servicegroup'])
             ->forRequest($this->getServerRequest());
 
         $this->getDocument()->add($suggestions);
@@ -252,7 +253,7 @@
         );
 
         if ($isChildrenTab) {
             $editor->getSuggestionUrl()->setParam('isChildrenTab');
         }
 
         $this->getDocument()->add($editor);
@@ -319,7 +320,7 @@
         return $query;
     }
 
     protected function fetchCommandTargets()
     {
         $filter = Filter::all(Filter::equal('child.redundancy_group.id', $this->groupId));
 

library/Icingadb/Model/Hostgroup.php

@@ -71,7 +71,8 @@ public function getDefaultSort()
     public function createBehaviors(Behaviors $behaviors)
     {
         $behaviors->add(new ReRoute([
-            'servicegroup'  => 'service.servicegroup'
+            'servicegroup'  => 'service.servicegroup',
+            'child'         => 'host.to.from'
         ]));
 
         $behaviors->add(new Binary([

library/Icingadb/Model/Servicegroup.php

@@ -72,7 +72,8 @@ public function createBehaviors(Behaviors $behaviors)
     {
         $behaviors->add(new ReRoute([
             'host'      => 'service.host',
-            'hostgroup' => 'service.hostgroup'
+            'hostgroup' => 'service.hostgroup',
+            'child'     => 'service.to.from'
         ]));
 
         $behaviors->add(new Binary([

library/Icingadb/Web/Control/SearchBar/ObjectSuggestions.php

@@ -43,6 +43,9 @@ class ObjectSuggestions extends Suggestions
     /** @var array */
     protected $customVarSources;
 
+    /** @var string[] Reduce {@see $customVarSources} to only given relations to fetch customVar for */
+    protected $onlyWithCustomVarSources = [];
+
     public function __construct()
     {
         $this->customVarSources = [
@@ -241,7 +244,7 @@ protected function fetchColumnSuggestions($searchTerm)
                 $search = $name . '[*]';
             }
 
-            foreach ($this->customVarSources as $relation => $label) {
+            foreach ($this->getCustomVarSources() as $relation => $label) {
                 if (isset($customVar->$relation)) {
                     if (! $titleAdded) {
                         $titleAdded = true;
@@ -284,8 +287,9 @@ protected function queryCustomvarConfig(string $searchTerm): Select
 
         $scalarQueries = [];
         $aggregates = ['flatname'];
+        $customVarSources = $this->getCustomVarSources();
         foreach ($resolver->getRelations($customVars->getModel()) as $name => $relation) {
-            if (isset($this->customVarSources[$name]) && $relation instanceof BelongsToMany) {
+            if (isset($customVarSources[$name]) && $relation instanceof BelongsToMany) {
                 $query = $customVars->createSubQuery(
                     $relation->getTarget(),
                     $resolver->qualifyPath($name, $tableName)
@@ -419,4 +423,37 @@ protected static function collectRelations(Resolver $resolver, Model $subject, a
             }
         }
     }
+
+    /**
+     * Get the custom variable sources to fetch customVar for
+     *
+     * If {@see $onlyWithCustomVarSources} is set, only return the sources that are in the list
+     *
+     * @return array
+     */
+    protected function getCustomVarSources(): array
+    {
+        if (! empty($this->onlyWithCustomVarSources)) {
+            $this->customVarSources = array_intersect_key(
+                $this->customVarSources,
+                array_flip($this->onlyWithCustomVarSources)
+            );
+        }
+
+        return $this->customVarSources;
+    }
+
+    /**
+     * Reduce {@see $customVarSources} to only given relations to fetch customVar for
+     *
+     * @param string[] $relations
+     *
+     * @return $this
+     */
+    public function onlyWithCustomVarSources(array $relations): self
+    {
+        $this->onlyWithCustomVarSources = $relations;
+
+        return $this;
+    }
 }