Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper dependency options while scheduling a downtime #1090

Closed
nilmerg opened this issue Nov 12, 2024 · 0 comments · Fixed by #1091
Closed

Proper dependency options while scheduling a downtime #1090

nilmerg opened this issue Nov 12, 2024 · 0 comments · Fixed by #1091
Assignees
Labels
bug Something isn't working
Milestone

Comments

@nilmerg
Copy link
Member

nilmerg commented Nov 12, 2024

Describe the bug

The downtime form for services doesn't allow to define child_options while Icinga 2's documentation doesn't limit them to host downtimes

Expected behavior

Service downtimes must be allowed to be scheduled with child_options.

@nilmerg nilmerg added the bug Something isn't working label Nov 12, 2024
@nilmerg nilmerg added this to the 1.2.0 milestone Nov 12, 2024
@nilmerg nilmerg self-assigned this Nov 12, 2024
nilmerg added a commit that referenced this issue Nov 12, 2024
Covers the full functionality of the schedule-downtime
endpoint of Icinga 2's api now.

fixes #1090
sukhwinder33445 pushed a commit that referenced this issue Nov 13, 2024
Covers the full functionality of the schedule-downtime
endpoint of Icinga 2's api now.

fixes #1090
nilmerg added a commit that referenced this issue Dec 9, 2024
Covers the full functionality of the schedule-downtime
endpoint of Icinga 2's api now.

fixes #1090
nilmerg added a commit that referenced this issue Dec 9, 2024
`ScheduleDowntimeCommand` is basically what
`ScheduleServiceDowntimeCommand` previously was. Though, with the
addition of `get|setForAllServices()` which was only part of
`ScheduleHostDowntimeCommand`.

`ScheduleDowntimeCommand::get|setChildOption()` is completely new and
replaces `ScheduleHostDowntimeCommand::get|setTriggered()`.

`ScheduleHostDowntimeCommand`, `PropagateHostDowntimeCommand` and
`ScheduleServiceDowntimeCommand` are now deprecated.

fixes #1090
@nilmerg nilmerg closed this as completed Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant