Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENHANCEMENT] Save the some information about the q-vectors that were generated. #564

Open
ChiCheng45 opened this issue Oct 2, 2024 · 0 comments · May be fixed by #634
Open

[ENHANCEMENT] Save the some information about the q-vectors that were generated. #564

ChiCheng45 opened this issue Oct 2, 2024 · 0 comments · May be fixed by #634
Labels
enhancement New feature or request

Comments

@ChiCheng45
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Currently, in MDANSE the q-vectors are generated randomly. This means that there is no way of reproducing results exactly when the seed was not set. It would be useful for MDANSE to output the exact q-vectors so that results can be reproduced and so that we could analyze the q-vectors that were generated to determine whether a sufficient number of them were generated and etc.

Describe the solution you'd like
Save the q-vectors that were generated to the MDA file.
@ChiCheng45 ChiCheng45 added the enhancement New feature or request label Oct 2, 2024
@ChiCheng45 ChiCheng45 changed the title [ENHANCEMENT] Save the some information about the q-points that were generated. [ENHANCEMENT] Save the some information about the q-vectors that were generated. Oct 2, 2024
@MBartkowiakSTFC MBartkowiakSTFC linked a pull request Jan 17, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Save Q vectors in the output file ISISNeutronMuon/MDANSE
1 participant
@ChiCheng45