Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create general tool for all the use cases #7

Open
perellonieto opened this issue Nov 30, 2017 · 2 comments
Open

Create general tool for all the use cases #7

perellonieto opened this issue Nov 30, 2017 · 2 comments

Comments

@perellonieto
Copy link
Member

Most of the actual tools have several things in common and could potentially be merged into one parent tool.

  • All of them expect a model for the initialisation
  • All of them expect input matrices with x_tr, or x_te, y_tr, or y_te
  • All of them expect the passed model to have a function to fit or partial_fit
  • All of them expect the model to generate some outputs like scores, or features

It could be possible to specify what functions to call during training and a dictionary to return the output values.

@tdiethe
Copy link
Member

tdiethe commented Dec 1, 2017

Sounds quite nice and flexible. You could probably make use of the scikit-learn base classes to do type checking (or just do duck-typing), see e.g. here

@perellonieto
Copy link
Member Author

That looks great, Thanks. I think I should use these BaseEstimators as a standard and create tools for each particular type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants