Skip to content

request access: when a user requests access to a file and is rejected, that action should be saved #8013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sbarbosadataverse opened this issue Jul 21, 2021 · 9 comments
Labels
Feature: Messaging Feature: Permissions Size: 30 A percentage of a sprint. 21 hours. (formerly size:33) Type: Feature a feature request Type: Suggestion an idea

Comments

@sbarbosadataverse
Copy link

At this time, rejected users are not saved in any way on the file level permissions page:

  1. This removes and doesn't allow the dataset owner to track their actual numbers of data requests on their restricted file/dataset
  2. This doesn't provide the user with a list of previous requests they can track and keep a record of rejected users
  3. This has been requested in support tickets into Harvard Dataverse repeatedly.
@sbarbosadataverse
Copy link
Author

@TaniaSchlatter I created this ticket for the request access-rejected user scenario

@cmbz
Copy link

cmbz commented Nov 18, 2024

2024/11/18: Upon review, we are keeping this feature request.

@qqmyers
Copy link
Member

qqmyers commented Feb 25, 2025

FWIW: The database is tracking granted and rejected requests these days, but there's no UI/API way to retrieve them yet. It would be relatively easy to add a parameter to the https://guides.dataverse.org/en/latest/api/dataaccess.html#list-file-access-requests call, e.g. ?includeHistory=true (mirroring the flag name from #11268 for curationStatus) to at least make the info accessible. It should also be possible to add the info to the current UI or SPA, but some guidance would be needed as to where to display it (showing the history for all files in the dataset page (permissions tab) could be a long list, could show it only on the file page? or?).

@pdurbin
Copy link
Member

pdurbin commented Feb 25, 2025

Right, as discussed in Slack as of the following PR there are three possible RequestState values that can be saved in the database: CREATED, GRANTED, REJECTED.

Yes, it would be great to expose this via API.

@cmbz
Copy link

cmbz commented Mar 3, 2025

2025/03/03

  • Would require a backend db change
  • Would require UI development

@qqmyers
Copy link
Member

qqmyers commented Mar 3, 2025

I don't think this requires a db change. It would require API/UI level work.

@cmbz
Copy link

cmbz commented Mar 3, 2025

2025/03/03

@scolapasta
Copy link
Contributor

Ah, I hadn't realized we were now storing rejected. So yes, if that's the case, no DB change; still needs UI design (especially to handle when large number of rejects exist).

@cmbz cmbz moved this to SPRINT- NEEDS SIZING in IQSS Dataverse Project Apr 7, 2025
@cmbz
Copy link

cmbz commented Apr 9, 2025

2025-04-09
Next steps for whomever picks up issue

  • Confirm APIs don't exist
  • Implement support in the API
  • Open an SPA issue for the UI part (design and implementation)
    Sizing at 30 initially

@cmbz cmbz added the Size: 30 A percentage of a sprint. 21 hours. (formerly size:33) label Apr 9, 2025
@cmbz cmbz moved this from SPRINT- NEEDS SIZING to SPRINT READY in IQSS Dataverse Project Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Messaging Feature: Permissions Size: 30 A percentage of a sprint. 21 hours. (formerly size:33) Type: Feature a feature request Type: Suggestion an idea
Projects
Status: SPRINT READY
Development

No branches or pull requests

5 participants