Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test all-periodic field layouts in PIC unit test #163

Open
1 task
matt-frey opened this issue May 3, 2023 · 0 comments
Open
1 task

Test all-periodic field layouts in PIC unit test #163

matt-frey opened this issue May 3, 2023 · 0 comments

Comments

@matt-frey
Copy link
Member

In GitLab by @vinciguerra_a on May 3, 2023, 12:07

The following discussion from !157 should be addressed:

  • @srikrrish started a discussion:

    I think we don't test the isAllPeriodic functionality. It would be good to test that also here.

    If we are using isAllPeriodic we can just do unif(0, domain[d]). Since isAllPeriodic tests more things only testing that is enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant