Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change DBO.php to use an ORM #110

Open
franc6 opened this issue Jun 22, 2020 · 0 comments
Open

Change DBO.php to use an ORM #110

franc6 opened this issue Jun 22, 2020 · 0 comments

Comments

@franc6
Copy link
Collaborator

franc6 commented Jun 22, 2020

Using a real ORM is probably desirable, instead of hand-coding SQL. This would also simplify unit tests for DBO.php, since it wouldn't need to use a real database, insert data, and verify the data coming out is what's expected. Instead, the unit tests could simply confirm that each method in DBO invokes the expected ORM methods.

I don't know much about ORMs in PHP, so I don't know which would be a good fit. Doctrine and Propel seem to be the most popular.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant