Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UNRESOLVABLE_SCHEMA and other warnings should not lead to unexpected behavior. #386

Open
Alan-Cha opened this issue Mar 30, 2021 · 0 comments
Open

UNRESOLVABLE_SCHEMA and other warnings should not lead to unexpected behavior. #386

Alan-Cha opened this issue Mar 30, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@Alan-Cha
Copy link
Collaborator

At least for the UNRESOLVABLE_SCHEMA warning, which has the mitigation "Ignore and continue. May lead to unexpected behavior." is alarming. It seems to me that in a case where a schema cannot be resolved, then it should instead use the arbitrary JSON type.

Related to discussion related in #330 where we discuss moving the allOf and oneOf resolution logic into the getSchemaTargetGraphQLType
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Alan-Cha