Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistencies resource loading in scheme file #660

Closed
tanyaveksler opened this issue Jan 14, 2024 · 1 comment
Closed

Inconsistencies resource loading in scheme file #660

tanyaveksler opened this issue Jan 14, 2024 · 1 comment
Labels
parsers Anything related to processing inputs

Comments

@tanyaveksler
Copy link
Member

Look in tests/istio_testcases/example_policies/online_boutique_multi_layer_from_live_cluster_test:
When moving sidecars.yaml resource from networkPolicyList to resourceList, this resource is not loaded.
However, when moving also rest of policy resources from networkPolicyList to resourceList (see below), the sidecars are loaded:

resourceList: onlineboutique-resources/

networkConfigList:
  - name: onlineboutique-resources
    resourceList:
      - onlineboutique-resources/
      - istio-gateways.yaml
      - network_policies.yaml
      - sidecars.yaml
    networkPolicyList:
#      - istio-gateways.yaml
#      - network_policies.yaml
#      - sidecars.yaml
@tanyaveksler tanyaveksler added the parsers Anything related to processing inputs label Jan 14, 2024
tanyaveksler added a commit that referenced this issue Jan 14, 2024
@tanyaveksler
Moved sidecars.yaml resources to networkPolicyList, to avoid possible…
858f711 
… problem with resource loading (see issue #660)

Signed-off-by: Tanya <[email protected]>
tanyaveksler added a commit that referenced this issue Jan 16, 2024
@tanyaveksler
Handle istio gateways and virtual services in live cluster (#656)
5a7a1e3 
* Fixed handling istio gateways and virtual services in live cluster

Signed-off-by: Tanya <[email protected]>

* Added multi-layer example with istio sidecars, gateways and virtual services, extracted from live cluster.
Added loading service entries from live cluster.

Signed-off-by: Tanya <[email protected]>

* Added expected runtime for a new test.
Fixed lint error.

Signed-off-by: Tanya <[email protected]>

* Fixed adding new test extracted from the live cluster (more resources added).

Signed-off-by: Tanya <[email protected]>

* Updated expected result due to dns entry renaming

Signed-off-by: Tanya <[email protected]>

* Updated expected result due to dns entry renaming

Signed-off-by: Tanya <[email protected]>

* Updated expected runtime of live cluster test.

Signed-off-by: Tanya <[email protected]>

* Moved sidecars.yaml resources to networkPolicyList, to avoid possible problem with resource loading (see issue #660)

Signed-off-by: Tanya <[email protected]>

* Loading all resources with '--all-namespaces' flag from live cluster.
Added jpg output to the example from live cluster.
Loading istio-specific resources (service enteries) only on istio runs.

Signed-off-by: Tanya <[email protected]>

* Added jpg output of online boutique from live cluster test.

Signed-off-by: Tanya <[email protected]>

* Added istio ingress gateway to the online boutique example from live cluster.

Signed-off-by: Tanya <[email protected]>

* Removed jpg generation from the example (to avoid jpg generation on every test run).

Signed-off-by: Tanya <[email protected]>

---------

Signed-off-by: Tanya <[email protected]>
@zivnevo
Copy link
Member

zivnevo commented Aug 14, 2024

Moved to NP-Guard repo. See here

@zivnevo zivnevo closed this as not planned Won't fix, can't repro, duplicate, stale Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
parsers Anything related to processing inputs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tanyaveksler @zivnevo