Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend default resource loading in live cluster to istio resources #657

Closed
tanyaveksler opened this issue Jan 7, 2024 · 2 comments
Closed

Extend default resource loading in live cluster to istio resources #657

tanyaveksler opened this issue Jan 7, 2024 · 2 comments
Assignees
@tanyaveksler
Labels
Istio Issues related to Istio support live cluster

Comments

@tanyaveksler
Copy link
Member

Currently there are the following possible combinations for handling resources in live cluster:

  • nca -r k8s -r istio => loads both k8s and istio reources
  • nca -r k8s => loads only k8s resources
  • no -r given => loads only k8s resources

We should probably change the default assumption that both k8s and istio resources are handled in live cluster.
What do you think, @zivnevo ?
@tanyaveksler tanyaveksler added Istio Issues related to Istio support live cluster labels Jan 7, 2024
@tanyaveksler tanyaveksler self-assigned this Jan 7, 2024
@tanyaveksler
Copy link
Member Author

We decided to remove the default (running without -r flag), and to give a warning in this case.

@zivnevo
Copy link
Member

zivnevo commented Aug 14, 2024

Moved to NP-Guard repo. See here

@zivnevo zivnevo closed this as not planned Won't fix, can't repro, duplicate, stale Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tanyaveksler tanyaveksler

Labels
Istio Issues related to Istio support live cluster
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tanyaveksler @zivnevo