Skip to content

feat(tekton): add support for waiting runs limit #6335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

feat(tekton): add support for waiting runs limit #6335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4004e13
feat(tekton): add support for waiting runs limit
briangleeson Jul 7, 2025
fdade5e
chore: more limit_waiting_run updates
briangleeson Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions ibm/service/cdtektonpipeline/data_source_ibm_cd_tekton_pipeline.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,6 +332,11 @@
Computed: true,
Description: "Mark the trigger as a favorite.",
},
"limit_waiting_runs": &schema.Schema{
Type: schema.TypeBool,
Computed: true,
Description: "Flag that will limit the trigger to a maximum of one waiting run. A newly triggered run will cause any other waiting run(s) to be automatically cancelled.",
},
"enable_events_from_forks": &schema.Schema{
Type: schema.TypeBool,
Computed: true,
Expand Down Expand Up @@ -812,6 +817,9 @@
if model.Favorite != nil {
modelMap["favorite"] = *model.Favorite
}
if model.LimitWaitingRuns != nil {

Check failure on line 820 in ibm/service/cdtektonpipeline/data_source_ibm_cd_tekton_pipeline.go

View workflow job for this annotation

GitHub Actions / Build 

model.LimitWaitingRuns undefined (type *cdtektonpipelinev2.Trigger has no field or method LimitWaitingRuns)
modelMap["limit_waiting_runs"] = *model.LimitWaitingRuns

Check failure on line 821 in ibm/service/cdtektonpipeline/data_source_ibm_cd_tekton_pipeline.go

View workflow job for this annotation

GitHub Actions / Build 

model.LimitWaitingRuns undefined (type *cdtektonpipelinev2.Trigger has no field or method LimitWaitingRuns)
}
if model.EnableEventsFromForks != nil {
modelMap["enable_events_from_forks"] = *model.EnableEventsFromForks
}
Expand Down Expand Up @@ -975,6 +983,9 @@
if model.Favorite != nil {
modelMap["favorite"] = *model.Favorite
}
if model.LimitWaitingRuns != nil {

Check failure on line 986 in ibm/service/cdtektonpipeline/data_source_ibm_cd_tekton_pipeline.go

View workflow job for this annotation

GitHub Actions / Build 

model.LimitWaitingRuns undefined (type *cdtektonpipelinev2.TriggerManualTrigger has no field or method LimitWaitingRuns)
modelMap["limit_waiting_runs"] = *model.LimitWaitingRuns

Check failure on line 987 in ibm/service/cdtektonpipeline/data_source_ibm_cd_tekton_pipeline.go

View workflow job for this annotation

GitHub Actions / Build 

model.LimitWaitingRuns undefined (type *cdtektonpipelinev2.TriggerManualTrigger has no field or method LimitWaitingRuns)
}
return modelMap, nil
}

Expand Down Expand Up @@ -1015,6 +1026,9 @@
if model.Favorite != nil {
modelMap["favorite"] = *model.Favorite
}
if model.LimitWaitingRuns != nil {

Check failure on line 1029 in ibm/service/cdtektonpipeline/data_source_ibm_cd_tekton_pipeline.go

View workflow job for this annotation

GitHub Actions / Build 

model.LimitWaitingRuns undefined (type *cdtektonpipelinev2.TriggerScmTrigger has no field or method LimitWaitingRuns)
modelMap["limit_waiting_runs"] = *model.LimitWaitingRuns

Check failure on line 1030 in ibm/service/cdtektonpipeline/data_source_ibm_cd_tekton_pipeline.go

View workflow job for this annotation

GitHub Actions / Build 

model.LimitWaitingRuns undefined (type *cdtektonpipelinev2.TriggerScmTrigger has no field or method LimitWaitingRuns)
}
if model.EnableEventsFromForks != nil {
modelMap["enable_events_from_forks"] = *model.EnableEventsFromForks
}
Expand Down Expand Up @@ -1071,6 +1085,9 @@
if model.Favorite != nil {
modelMap["favorite"] = *model.Favorite
}
if model.LimitWaitingRuns != nil {

Check failure on line 1088 in ibm/service/cdtektonpipeline/data_source_ibm_cd_tekton_pipeline.go

View workflow job for this annotation

GitHub Actions / Build 

model.LimitWaitingRuns undefined (type *cdtektonpipelinev2.TriggerTimerTrigger has no field or method LimitWaitingRuns)
modelMap["limit_waiting_runs"] = *model.LimitWaitingRuns

Check failure on line 1089 in ibm/service/cdtektonpipeline/data_source_ibm_cd_tekton_pipeline.go

View workflow job for this annotation

GitHub Actions / Build 

model.LimitWaitingRuns undefined (type *cdtektonpipelinev2.TriggerTimerTrigger has no field or method LimitWaitingRuns)
}
if model.Cron != nil {
modelMap["cron"] = *model.Cron
}
Expand Down Expand Up @@ -1117,6 +1134,9 @@
if model.Favorite != nil {
modelMap["favorite"] = *model.Favorite
}
if model.LimitWaitingRuns != nil {

Check failure on line 1137 in ibm/service/cdtektonpipeline/data_source_ibm_cd_tekton_pipeline.go

View workflow job for this annotation

GitHub Actions / Build 

model.LimitWaitingRuns undefined (type *cdtektonpipelinev2.TriggerGenericTrigger has no field or method LimitWaitingRuns)
modelMap["limit_waiting_runs"] = *model.LimitWaitingRuns

Check failure on line 1138 in ibm/service/cdtektonpipeline/data_source_ibm_cd_tekton_pipeline.go

View workflow job for this annotation

GitHub Actions / Build 

model.LimitWaitingRuns undefined (type *cdtektonpipelinev2.TriggerGenericTrigger has no field or method LimitWaitingRuns)
}
if model.Secret != nil {
secretMap, err := DataSourceIBMCdTektonPipelineGenericSecretToMap(model.Secret)
if err != nil {
Expand Down
10 changes: 10 additions & 0 deletions ibm/service/cdtektonpipeline/data_source_ibm_cd_tekton_pipeline_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,6 +431,7 @@ func TestDataSourceIBMCdTektonPipelineTriggerToMap(t *testing.T) {
model["max_concurrent_runs"] = int(4)
model["enabled"] = true
model["favorite"] = false
model["limit_waiting_runs"] = false
model["enable_events_from_forks"] = false
model["source"] = []map[string]interface{}{triggerSourceModel}
model["events"] = []string{"push", "pull_request"}
Expand Down Expand Up @@ -491,6 +492,7 @@ func TestDataSourceIBMCdTektonPipelineTriggerToMap(t *testing.T) {
model.MaxConcurrentRuns = core.Int64Ptr(int64(4))
model.Enabled = core.BoolPtr(true)
model.Favorite = core.BoolPtr(false)
model.LimitWaitingRuns = core.BoolPtr(false)
model.EnableEventsFromForks = core.BoolPtr(false)
model.Source = triggerSourceModel
model.Events = []string{"push", "pull_request"}
Expand Down Expand Up @@ -677,6 +679,7 @@ func TestDataSourceIBMCdTektonPipelineTriggerManualTriggerToMap(t *testing.T) {
model["max_concurrent_runs"] = int(4)
model["enabled"] = true
model["favorite"] = false
model["limit_waiting_runs"] = false

assert.Equal(t, result, model)
}
Expand Down Expand Up @@ -707,6 +710,7 @@ func TestDataSourceIBMCdTektonPipelineTriggerManualTriggerToMap(t *testing.T) {
model.MaxConcurrentRuns = core.Int64Ptr(int64(4))
model.Enabled = core.BoolPtr(true)
model.Favorite = core.BoolPtr(false)
model.LimitWaitingRuns = core.BoolPtr(false)

result, err := cdtektonpipeline.DataSourceIBMCdTektonPipelineTriggerManualTriggerToMap(model)
assert.Nil(t, err)
Expand Down Expand Up @@ -756,6 +760,7 @@ func TestDataSourceIBMCdTektonPipelineTriggerScmTriggerToMap(t *testing.T) {
model["max_concurrent_runs"] = int(4)
model["enabled"] = true
model["favorite"] = false
model["limit_waiting_runs"] = false
model["enable_events_from_forks"] = false
model["source"] = []map[string]interface{}{triggerSourceModel}
model["events"] = []string{"push", "pull_request"}
Expand Down Expand Up @@ -805,6 +810,7 @@ func TestDataSourceIBMCdTektonPipelineTriggerScmTriggerToMap(t *testing.T) {
model.MaxConcurrentRuns = core.Int64Ptr(int64(4))
model.Enabled = core.BoolPtr(true)
model.Favorite = core.BoolPtr(false)
model.LimitWaitingRuns = core.BoolPtr(false)
model.EnableEventsFromForks = core.BoolPtr(false)
model.Source = triggerSourceModel
model.Events = []string{"push", "pull_request"}
Expand Down Expand Up @@ -843,6 +849,7 @@ func TestDataSourceIBMCdTektonPipelineTriggerTimerTriggerToMap(t *testing.T) {
model["max_concurrent_runs"] = int(4)
model["enabled"] = true
model["favorite"] = false
model["limit_waiting_runs"] = false
model["cron"] = "testString"
model["timezone"] = "America/Los_Angeles, CET, Europe/London, GMT, US/Eastern, or UTC"

Expand Down Expand Up @@ -875,6 +882,7 @@ func TestDataSourceIBMCdTektonPipelineTriggerTimerTriggerToMap(t *testing.T) {
model.MaxConcurrentRuns = core.Int64Ptr(int64(4))
model.Enabled = core.BoolPtr(true)
model.Favorite = core.BoolPtr(false)
model.LimitWaitingRuns = core.BoolPtr(false)
model.Cron = core.StringPtr("testString")
model.Timezone = core.StringPtr("America/Los_Angeles, CET, Europe/London, GMT, US/Eastern, or UTC")

Expand Down Expand Up @@ -918,6 +926,7 @@ func TestDataSourceIBMCdTektonPipelineTriggerGenericTriggerToMap(t *testing.T) {
model["max_concurrent_runs"] = int(4)
model["enabled"] = true
model["favorite"] = false
model["limit_waiting_runs"] = false
model["secret"] = []map[string]interface{}{genericSecretModel}
model["webhook_url"] = "testString"
model["filter"] = "event.type == 'message' && event.text.contains('urgent')"
Expand Down Expand Up @@ -958,6 +967,7 @@ func TestDataSourceIBMCdTektonPipelineTriggerGenericTriggerToMap(t *testing.T) {
model.MaxConcurrentRuns = core.Int64Ptr(int64(4))
model.Enabled = core.BoolPtr(true)
model.Favorite = core.BoolPtr(false)
model.LimitWaitingRuns = core.BoolPtr(false)
model.Secret = genericSecretModel
model.WebhookURL = core.StringPtr("testString")
model.Filter = core.StringPtr("event.type == 'message' && event.text.contains('urgent')")
Expand Down
11 changes: 11 additions & 0 deletions ibm/service/cdtektonpipeline/data_source_ibm_cd_tekton_pipeline_trigger.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,11 @@ func DataSourceIBMCdTektonPipelineTrigger() *schema.Resource {
Computed: true,
Description: "Mark the trigger as a favorite.",
},
"limit_waiting_runs": &schema.Schema{
Type: schema.TypeBool,
Computed: true,
Description: "Flag that will limit the trigger to a maximum of one waiting run. A newly triggered run will cause any other waiting run(s) to be automatically cancelled.",
},
"enable_events_from_forks": &schema.Schema{
Type: schema.TypeBool,
Computed: true,
Expand Down Expand Up @@ -384,6 +389,12 @@ func dataSourceIBMCdTektonPipelineTriggerRead(context context.Context, d *schema
}
}

if !core.IsNil(trigger.LimitWaitingRuns) {
if err = d.Set("limit_waiting_runs", trigger.LimitWaitingRuns); err != nil {
return flex.DiscriminatedTerraformErrorf(err, fmt.Sprintf("Error setting limit_waiting_runs: %s", err), "(Data) ibm_cd_tekton_pipeline_trigger", "read", "set-limit_waiting_runs").GetDiag()
}
}

if !core.IsNil(trigger.EnableEventsFromForks) {
if err = d.Set("enable_events_from_forks", trigger.EnableEventsFromForks); err != nil {
return flex.DiscriminatedTerraformErrorf(err, fmt.Sprintf("Error setting enable_events_from_forks: %s", err), "(Data) ibm_cd_tekton_pipeline_trigger", "read", "set-enable_events_from_forks").GetDiag()
Expand Down
9 changes: 6 additions & 3 deletions ibm/service/cdtektonpipeline/data_source_ibm_cd_tekton_pipeline_trigger_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ func TestAccIBMCdTektonPipelineTriggerDataSourceAllArgs(t *testing.T) {
triggerMaxConcurrentRuns := fmt.Sprintf("%d", acctest.RandIntRange(10, 100))
triggerEnabled := "false"
triggerFavorite := "true"
triggerLimitWaitingRuns := "true"
triggerEnableEventsFromForks := "true"
triggerFilter := fmt.Sprintf("tf_filter_%d", acctest.RandIntRange(10, 100))
triggerCron := fmt.Sprintf("tf_cron_%d", acctest.RandIntRange(10, 100))
Expand All @@ -61,7 +62,7 @@ func TestAccIBMCdTektonPipelineTriggerDataSourceAllArgs(t *testing.T) {
Providers: acc.TestAccProviders,
Steps: []resource.TestStep{
resource.TestStep{
Config: testAccCheckIBMCdTektonPipelineTriggerDataSourceConfig(triggerPipelineID, triggerType, triggerName, triggerEventListener, triggerMaxConcurrentRuns, triggerEnabled, triggerFavorite, triggerEnableEventsFromForks, triggerFilter, triggerCron, triggerTimezone),
Config: testAccCheckIBMCdTektonPipelineTriggerDataSourceConfig(triggerPipelineID, triggerType, triggerName, triggerEventListener, triggerMaxConcurrentRuns, triggerEnabled, triggerFavorite, triggerLimitWaitingRuns, triggerEnableEventsFromForks, triggerFilter, triggerCron, triggerTimezone),
Check: resource.ComposeTestCheckFunc(
resource.TestCheckResourceAttrSet("data.ibm_cd_tekton_pipeline_trigger.cd_tekton_pipeline_trigger_instance", "id"),
resource.TestCheckResourceAttrSet("data.ibm_cd_tekton_pipeline_trigger.cd_tekton_pipeline_trigger_instance", "pipeline_id"),
Expand All @@ -74,6 +75,7 @@ func TestAccIBMCdTektonPipelineTriggerDataSourceAllArgs(t *testing.T) {
resource.TestCheckResourceAttrSet("data.ibm_cd_tekton_pipeline_trigger.cd_tekton_pipeline_trigger_instance", "max_concurrent_runs"),
resource.TestCheckResourceAttrSet("data.ibm_cd_tekton_pipeline_trigger.cd_tekton_pipeline_trigger_instance", "enabled"),
resource.TestCheckResourceAttrSet("data.ibm_cd_tekton_pipeline_trigger.cd_tekton_pipeline_trigger_instance", "favorite"),
resource.TestCheckResourceAttrSet("data.ibm_cd_tekton_pipeline_trigger.cd_tekton_pipeline_trigger_instance", "limit_waiting_runs"),
),
},
},
Expand Down Expand Up @@ -147,7 +149,7 @@ func testAccCheckIBMCdTektonPipelineTriggerDataSourceConfigBasic(triggerPipeline
`, rgName, tcName, triggerType, triggerName, triggerEventListener)
}

func testAccCheckIBMCdTektonPipelineTriggerDataSourceConfig(triggerPipelineID string, triggerType string, triggerName string, triggerEventListener string, triggerMaxConcurrentRuns string, triggerEnabled string, triggerFavorite string, triggerEnableEventsFromForks string, triggerFilter string, triggerCron string, triggerTimezone string) string {
func testAccCheckIBMCdTektonPipelineTriggerDataSourceConfig(triggerPipelineID string, triggerType string, triggerName string, triggerEventListener string, triggerMaxConcurrentRuns string, triggerEnabled string, triggerFavorite string, triggerLimitWaitingRuns string, triggerEnableEventsFromForks string, triggerFilter string, triggerCron string, triggerTimezone string) string {
rgName := acc.CdResourceGroupName
tcName := fmt.Sprintf("tf_name_%d", acctest.RandIntRange(10, 100))
return fmt.Sprintf(`
Expand Down Expand Up @@ -205,6 +207,7 @@ func testAccCheckIBMCdTektonPipelineTriggerDataSourceConfig(triggerPipelineID st
type = "%s"
name = "%s"
event_listener = "%s"
limit_waiting_runs = %s
max_concurrent_runs = %s
enabled = %s
favorite = %s
Expand All @@ -214,7 +217,7 @@ func testAccCheckIBMCdTektonPipelineTriggerDataSourceConfig(triggerPipelineID st
pipeline_id = ibm_cd_tekton_pipeline_trigger.cd_tekton_pipeline_trigger_instance.pipeline_id
trigger_id = ibm_cd_tekton_pipeline_trigger.cd_tekton_pipeline_trigger_instance.trigger_id
}
`, rgName, tcName, triggerType, triggerName, triggerEventListener, triggerMaxConcurrentRuns, triggerEnabled, triggerFavorite)
`, rgName, tcName, triggerType, triggerName, triggerEventListener, triggerLimitWaitingRuns, triggerMaxConcurrentRuns, triggerEnabled, triggerFavorite)
}

func TestDataSourceIBMCdTektonPipelineTriggerTriggerPropertyToMap(t *testing.T) {
Expand Down
21 changes: 21 additions & 0 deletions ibm/service/cdtektonpipeline/resource_ibm_cd_tekton_pipeline.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,6 +401,12 @@ func ResourceIBMCdTektonPipeline() *schema.Resource {
Computed: true,
Description: "Mark the trigger as a favorite.",
},
"limit_waiting_runs": &schema.Schema{
Type: schema.TypeBool,
Optional: true,
Computed: true,
Description: "Flag that will limit the trigger to a maximum of one waiting run. A newly triggered run will cause any other waiting run(s) to be automatically cancelled.",
},
"enable_events_from_forks": &schema.Schema{
Type: schema.TypeBool,
Optional: true,
Expand Down Expand Up @@ -1023,6 +1029,9 @@ func ResourceIBMCdTektonPipelineTriggerToMap(model cdtektonpipelinev2.TriggerInt
if model.Favorite != nil {
modelMap["favorite"] = *model.Favorite
}
if model.LimitWaitingRuns != nil {
modelMap["limit_waiting_runs"] = *model.LimitWaitingRuns
}
if model.EnableEventsFromForks != nil {
modelMap["enable_events_from_forks"] = *model.EnableEventsFromForks
}
Expand Down Expand Up @@ -1172,6 +1181,9 @@ func ResourceIBMCdTektonPipelineTriggerManualTriggerToMap(model *cdtektonpipelin
if model.Favorite != nil {
modelMap["favorite"] = *model.Favorite
}
if model.LimitWaitingRuns != nil {
modelMap["limit_waiting_runs"] = *model.LimitWaitingRuns
}
return modelMap, nil
}

Expand Down Expand Up @@ -1212,6 +1224,9 @@ func ResourceIBMCdTektonPipelineTriggerScmTriggerToMap(model *cdtektonpipelinev2
if model.Favorite != nil {
modelMap["favorite"] = *model.Favorite
}
if model.LimitWaitingRuns != nil {
modelMap["limit_waiting_runs"] = *model.LimitWaitingRuns
}
if model.EnableEventsFromForks != nil {
modelMap["enable_events_from_forks"] = *model.EnableEventsFromForks
}
Expand Down Expand Up @@ -1268,6 +1283,9 @@ func ResourceIBMCdTektonPipelineTriggerTimerTriggerToMap(model *cdtektonpipeline
if model.Favorite != nil {
modelMap["favorite"] = *model.Favorite
}
if model.LimitWaitingRuns != nil {
modelMap["limit_waiting_runs"] = *model.LimitWaitingRuns
}
if model.Cron != nil {
modelMap["cron"] = *model.Cron
}
Expand Down Expand Up @@ -1314,6 +1332,9 @@ func ResourceIBMCdTektonPipelineTriggerGenericTriggerToMap(model *cdtektonpipeli
if model.Favorite != nil {
modelMap["favorite"] = *model.Favorite
}
if model.LimitWaitingRuns != nil {
modelMap["limit_waiting_runs"] = *model.LimitWaitingRuns
}
if model.Secret != nil {
secretMap, err := ResourceIBMCdTektonPipelineGenericSecretToMap(model.Secret)
if err != nil {
Expand Down
2 changes: 1 addition & 1 deletion ibm/service/cdtektonpipeline/resource_ibm_cd_tekton_pipeline_definition.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ func resourceIBMCdTektonPipelineDefinitionRead(context context.Context, d *schem
return flex.DiscriminatedTerraformErrorf(err, err.Error(), "ibm_cd_tekton_pipeline_definition", "read", "set-href").GetDiag()
}
}
if err = d.Set("pipeline_id", parts[0]); err != nil {
if err = d.Set("pipeline_id", d.Get("pipeline_id").(string)); err != nil {
err = fmt.Errorf("Error setting pipeline_id: %s", err)
return flex.DiscriminatedTerraformErrorf(err, err.Error(), "ibm_cd_tekton_pipeline_definition", "read", "set-pipeline_id").GetDiag()
}
Expand Down
2 changes: 1 addition & 1 deletion ibm/service/cdtektonpipeline/resource_ibm_cd_tekton_pipeline_property.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ func resourceIBMCdTektonPipelinePropertyRead(context context.Context, d *schema.
return tfErr.GetDiag()
}

if err = d.Set("pipeline_id", parts[0]); err != nil {
if err = d.Set("pipeline_id", d.Get("pipeline_id").(string)); err != nil {
err = fmt.Errorf("Error setting pipeline_id: %s", err)
return flex.DiscriminatedTerraformErrorf(err, err.Error(), "ibm_cd_tekton_pipeline_property", "read", "set-pipeline_id").GetDiag()
}
Expand Down
10 changes: 10 additions & 0 deletions ibm/service/cdtektonpipeline/resource_ibm_cd_tekton_pipeline_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,6 +457,7 @@ func TestResourceIBMCdTektonPipelineTriggerToMap(t *testing.T) {
model["max_concurrent_runs"] = int(4)
model["enabled"] = true
model["favorite"] = false
model["limit_waiting_runs"] = false
model["enable_events_from_forks"] = false
model["source"] = []map[string]interface{}{triggerSourceModel}
model["events"] = []string{"push", "pull_request"}
Expand Down Expand Up @@ -517,6 +518,7 @@ func TestResourceIBMCdTektonPipelineTriggerToMap(t *testing.T) {
model.MaxConcurrentRuns = core.Int64Ptr(int64(4))
model.Enabled = core.BoolPtr(true)
model.Favorite = core.BoolPtr(false)
model.LimitWaitingRuns = core.BoolPtr(false)
model.EnableEventsFromForks = core.BoolPtr(false)
model.Source = triggerSourceModel
model.Events = []string{"push", "pull_request"}
Expand Down Expand Up @@ -683,6 +685,7 @@ func TestResourceIBMCdTektonPipelineTriggerManualTriggerToMap(t *testing.T) {
model["max_concurrent_runs"] = int(4)
model["enabled"] = true
model["favorite"] = false
model["limit_waiting_runs"] = false

assert.Equal(t, result, model)
}
Expand Down Expand Up @@ -713,6 +716,7 @@ func TestResourceIBMCdTektonPipelineTriggerManualTriggerToMap(t *testing.T) {
model.MaxConcurrentRuns = core.Int64Ptr(int64(4))
model.Enabled = core.BoolPtr(true)
model.Favorite = core.BoolPtr(false)
model.LimitWaitingRuns = core.BoolPtr(false)

result, err := cdtektonpipeline.ResourceIBMCdTektonPipelineTriggerManualTriggerToMap(model)
assert.Nil(t, err)
Expand Down Expand Up @@ -762,6 +766,7 @@ func TestResourceIBMCdTektonPipelineTriggerScmTriggerToMap(t *testing.T) {
model["max_concurrent_runs"] = int(4)
model["enabled"] = true
model["favorite"] = false
model["limit_waiting_runs"] = false
model["enable_events_from_forks"] = false
model["source"] = []map[string]interface{}{triggerSourceModel}
model["events"] = []string{"push", "pull_request"}
Expand Down Expand Up @@ -811,6 +816,7 @@ func TestResourceIBMCdTektonPipelineTriggerScmTriggerToMap(t *testing.T) {
model.MaxConcurrentRuns = core.Int64Ptr(int64(4))
model.Enabled = core.BoolPtr(true)
model.Favorite = core.BoolPtr(false)
model.LimitWaitingRuns = core.BoolPtr(false)
model.EnableEventsFromForks = core.BoolPtr(false)
model.Source = triggerSourceModel
model.Events = []string{"push", "pull_request"}
Expand Down Expand Up @@ -849,6 +855,7 @@ func TestResourceIBMCdTektonPipelineTriggerTimerTriggerToMap(t *testing.T) {
model["max_concurrent_runs"] = int(4)
model["enabled"] = true
model["favorite"] = false
model["limit_waiting_runs"] = false
model["cron"] = "testString"
model["timezone"] = "America/Los_Angeles, CET, Europe/London, GMT, US/Eastern, or UTC"

Expand Down Expand Up @@ -881,6 +888,7 @@ func TestResourceIBMCdTektonPipelineTriggerTimerTriggerToMap(t *testing.T) {
model.MaxConcurrentRuns = core.Int64Ptr(int64(4))
model.Enabled = core.BoolPtr(true)
model.Favorite = core.BoolPtr(false)
model.LimitWaitingRuns = core.BoolPtr(false)
model.Cron = core.StringPtr("testString")
model.Timezone = core.StringPtr("America/Los_Angeles, CET, Europe/London, GMT, US/Eastern, or UTC")

Expand Down Expand Up @@ -924,6 +932,7 @@ func TestResourceIBMCdTektonPipelineTriggerGenericTriggerToMap(t *testing.T) {
model["max_concurrent_runs"] = int(4)
model["enabled"] = true
model["favorite"] = false
model["limit_waiting_runs"] = false
model["secret"] = []map[string]interface{}{genericSecretModel}
model["webhook_url"] = "testString"
model["filter"] = "event.type == 'message' && event.text.contains('urgent')"
Expand Down Expand Up @@ -964,6 +973,7 @@ func TestResourceIBMCdTektonPipelineTriggerGenericTriggerToMap(t *testing.T) {
model.MaxConcurrentRuns = core.Int64Ptr(int64(4))
model.Enabled = core.BoolPtr(true)
model.Favorite = core.BoolPtr(false)
model.LimitWaitingRuns = core.BoolPtr(false)
model.Secret = genericSecretModel
model.WebhookURL = core.StringPtr("testString")
model.Filter = core.StringPtr("event.type == 'message' && event.text.contains('urgent')")
Expand Down
Loading
Loading